Fix Javascript warnings showing up with the new SpiderMonkey

[Yves]

The new SpiderMonkey (#1886) prints more warnings and errors about potentially buggy code. The idea is to have a close look at all these warnings and fix them in a sensible way instead of just trying to get rid of them somehow. If you know any of the affected files especially well or if you're otherwise interested to help, feel free! :) I'll focus on other TODOs for the upgrade first, but if a contributor without commit access proposes a fix, I'll review it quickly (you don't have to fix all warnings at once).

WARNING: JavaScript warning: simulation/helpers/InitGame.js line 31 reference to undefined property settings.mapType
WARNING: JavaScript warning: simulation/components/TechnologyManager.js line 123 reference to undefined property template.requirements
WARNING: JavaScript warning: simulation/components/ProductionQueue.js line 111 reference to undefined property template.Promotion
WARNING: JavaScript warning: simulation/components/Player.js line 479 reference to undefined property this.diplomacy[id]
WARNING: JavaScript warning: simulation/components/Player.js line 386 reference to undefined property this.diplomacy[idx]
WARNING: JavaScript warning: simulation/components/GuiInterface.js line 931 reference to undefined property this.entsRallyPointsDisplayed
WARNING: JavaScript warning: simulation/components/GuiInterface.js line 928 reference to undefined property this.entsRallyPointsDisplayed
WARNING: JavaScript warning: simulation/components/GuiInterface.js line 664 reference to undefined property template.icon
WARNING: JavaScript warning: simulation/components/GuiInterface.js line 1757 reference to undefined property waterPoints[start]
WARNING: JavaScript warning: simulation/components/Attack.js line 490 reference to undefined property missileDirection.y
WARNING: JavaScript warning: simulation/ai/common-api/map-module.js line 78 reference to undefined property this.map[(x + (y * this.width))]
WARNING: JavaScript warning: simulation/ai/common-api/map-module.js line 40 reference to undefined property this.map[(q[0] + (this.width * q[1]))]
WARNING: JavaScript warning: simulation/ai/common-api/terrain-analysis-pathfinder.js line 207 reference to undefined property this.widthMap[index]
WARNING: JavaScript warning: simulation/ai/aegis/worker.js line 148 reference to undefined property this.ent.unitAIState(...).split(...)[2]
WARNING: JavaScript warning: simulation/ai/aegis/defence.js line 146 reference to undefined property this.armyMergeSize
WARNING: JavaScript warning: simulation/ai/aegis/base-manager.js line 118 reference to undefined property HQ.basesMap.map[((x + xi) + ((y + yi) * width))]
WARNING: JavaScript warning: simulation/ai/petra/baseManager.js line 248 reference to undefined property supply.dropsite

[wraitii]

In 14578:

Should fix AI warnings (refs #2372).
Slight configuration changes to improve the early-game slightly, WIP.

[Yves]

These warnings didn't appear anymore in another game after r14578:

WARNING: JavaScript warning: simulation/ai/aegis/aegis.js line 48 reference to undefined property sharedScript.events
WARNING: JavaScript warning: simulation/ai/aegis/base-manager.js line 904 reference to undefined property this.targetNumBuilders
WARNING: JavaScript warning: simulation/ai/aegis/base-manager.js line 587 reference to undefined property gameState.playedTurn
WARNING: JavaScript warning: simulation/ai/aegis/headquarters.js line 450 reference to undefined property this.wantedRates
WARNING: JavaScript warning: simulation/ai/common-api/terrain-analysis-pathfinder.js line 208 reference to undefined property this.index

I've tested a longer game and there still some warnings in the AI. I've updated the list in the ticket description (removed solved warnings and added new ones).

[leper]

In 14579:

Fix a bug in TestAllMemberFunction and initialize a variable in cmpBattleDetection. Refs #2372.

[wraitii]

In 14582:

Various improvements to AI's early game. Simplify some code and improve on other. Add a few different strategies (Rush/normal/boom, quite basic for now, refs #2344).
Aegis should mostly respect tech limitations so I'll ref #1964.
I'm going to go with #2364 is fixed, the AI should be more efficient in early-game, and late-game is a known problem.
Fixes #2274 and fixes #2379.
Refs #2372 as it should fix several of those warnings for AIs.
Fixes #2256 with a new bartering system, in parts taken from mimo's patch.

[Yves]

In 14802:

Fixes warnings printed by the new SpiderMonkey.
Sets SelectableInGameSetup to true in all civ json files that didn't have it set.
Having this value set to undefined (not set) was interpreted as true, which is quite arbitrary.
With the new SpiderMonkey a warning will be printed if the value is undefined.
This avoids ambiguity but makes the setting mandatory.

Refs #2372

[Yves]

In 14862:

Silences some warnings that show up on the gamesetup screen with the new SpiderMonkey without changing any behaviour.

Refs #2372

[Yves]

In 14863:

Fixes warning showing up with the new SpiderMonkey.
The changed return value isn't related but returning false makes more sense there IMO.

Refs #2372

[scythetwirler]

In 14923:

Fixes SpiderMonkey warnings in the lobby.

Refs #2372

[leper]

In 14933:

Fix some JS warnings. Refs #2372.

[Stan]

there is a warning with cmd.metadata being undefined line 223 in command.js when shift + recruiting units. I tried setting cmd.metadata to 0; but i guess i did it in the wrong file.

[gallaecio]

In 15030:

Fixed warnings in ‘gui’ due to the new SpiderMonkey

Refs #2372

[scythetwirler]

Pushed (r15127).

[leper]

Some of the warnings in the description have probably been fixed, while others could be missing. It would be nice to get an updated listing of warnings.

[leper]

Closing this as most of those are fixed and if there are some remaining we can open new tickets for them.