Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#2419 closed defect (fixed)

Please include unminified jquery JS files in source tarball

Reported by: Vincent Cheng Owned by: leper
Priority: Nice to Have Milestone: Alpha 20
Component: Build & Packages Keywords:
Cc: Yves Patch:

Description (last modified by fabio)

Forwarded from Debian BTS: http://bugs.debian.org/735349

Would it be possible to include unminified versions of the various jquery files included in the source tarball? Debian considers minified/obfuscated javascript to be non-source files, and so the original unminified files need to be included as well to be DFSG-free.

The files in question are:

and maybe:

i.e. please consider placing these files (also attached) into the same directory as the corresponding minified version:

For "jquery.easyui.min.js", is it safe to assume that everything in source/tools/jsdebugger/js/lib/jquery.easyui/src/ corresponds to the source code for that file?

Thanks!

Attachments (2)

jquery-1.8.3.js (259.8 KB ) - added by Vincent Cheng 10 years ago.
jquery 1.8.3 unminified
jquery-1.8.0.js (252.3 KB ) - added by Vincent Cheng 10 years ago.
jquery 1.8.0 unminified

Download all attachments as: .zip

Change History (10)

by Vincent Cheng, 10 years ago

Attachment: jquery-1.8.3.js added

jquery 1.8.3 unminified

by Vincent Cheng, 10 years ago

Attachment: jquery-1.8.0.js added

jquery 1.8.0 unminified

comment:1 by Vincent Cheng, 10 years ago

Description: modified (diff)

comment:2 by Vincent Cheng, 10 years ago

IRC:

<Yves`> 09:35:23> vincent_c: would it be ok to just exclude the jsdebugger from the packages until we have figured out how it will work in the future?

Yes (although I'd still have to repack the source tarball to remove those minified js files for the sake of DFSG-compatibility).

comment:3 by historic_bruno, 10 years ago

Cc: Yves added

comment:4 by fabio, 10 years ago

Is there a real benefit on using the minified js?

in reply to:  4 comment:5 by sanderd17, 10 years ago

Replying to fabio:

Is there a real benefit on using the minified js?

They're smaller, and depending on the minifier, sometimes also faster. But both advantages are worthless to us, as most space is taken by the artwork anyway (a bit bigger source file doesn't matter), and it's jQuery specifically is only used by the JS debugger. Which isn't used a lot, so speed doesn't matter a lot.

The biggest advantage for some minified JS libraries is that the minified version is only one file, while unminified can be a complete directory structure. Though with jQuery, it seems the complete library is also available as unminified.

But, because the JS debugger is broken, we should either delete the complete thing, or leave it as is. By replacing the library, we can't check if everything still works as it should, and it's best to not break the debugger on multiple places if we eventually want to get it working again.

comment:6 by fabio, 10 years ago

Description: modified (diff)

comment:7 by leper, 8 years ago

Owner: set to leper
Resolution: fixed
Status: newclosed

comment:8 by leper, 8 years ago

Milestone: BacklogAlpha 20

Those files are removed since the JSDebugger is gone too.

Note: See TracTickets for help on using tickets.