[PATCH] Ship Sinking Refinement

[brian]

It would be nice if sunken ships were visible after a naval battle. The ships would sink quickly utilizing the current behavior until they reach the bottom. Upon reaching the bottom, they would sink at a slow rate like regular units.

This will be somewhat tricky as the sink rate (SinkRate) and sink acceleration (SinkAccel) are defined on the basic ship template. It would need to be determined where to get the slower decay values.

The relevant C++ file is: source/simulation2/components/CCmpDecay.cpp

This ticket is somewhat related to: ​http://trac.wildfiregames.com/ticket/2986

[Itms]

Hello Demiguise, and thanks for that patch!

I tested it and I must say I find the result really neat. :) However I find the slow sinking phase really long, maybe you could tweak this to make it a bit quicker.

About the code, I think you should change the way you reorganized the template. Indeed, what you call the "slow sinking" is actually the normal "sinking" for land units, so you should better add into <SinkingAnim/> a "rapid sinking" for more consistency. That should make your code in the Decay component cleaner too.

About the style, just fix the indentation in the xml, and avoid putting comments just after brackets, better separate this into two lines. I also see little mistakes, just read thoroughly wiki:Coding_Conventions if you didn't already.

I'll push this ticket to the next milestone because we're close to feature freeze, so I'm afraid we won't add your code to Alpha 17. However, we're looking forward your contribution for the next release! Thanks again for working on this.

[Demiguise]

Thanks for the feedback and sorry for the late reply. I'll get on this and have something for you at the weekend.

[mimo]

pushing to backlog as no activity since months

[Imarok]

Move tickets to Simulation as UI & Simulation got some sub components.

[Freagarach]

Refs. #1501, but this is more specific therefore left open.