Opened 10 years ago

Closed 10 years ago

Last modified 4 years ago

#2551 closed defect (fixed)

Fix OS X library build script to rebuild when SpiderMonkey version changes

Reported by: historic_bruno Owned by: ben
Priority: Should Have Milestone: Alpha 17
Component: Build & Packages Keywords: simple
Cc: Patch:

Description

There's a bug in build-osx-libs.sh​, it should check the README.txt file that comes with SpiderMonkey and which changes when we upgrade, so it can correctly rebuild. The separate build.sh​ for SpiderMonkey already does that.

Change History (3)

comment:1 by ben, 10 years ago

Owner: set to ben
Resolution: → fixed
Status: new → closed

In 15696:

Fixes build-osx-libs.sh to rebuild SpiderMonkey when its README.txt changes, fixes #2551

comment:2 by Itms, 10 years ago

Milestone: Backlog → Alpha 17

comment:3 by Itms, 4 years ago

In 23686:

Check the library version instead of the mtime of the already-built guard file in build-osx-libs.sh

Use a suffix for bundled libraries in order to rebuild them when we patch them, refs #2551.

Patch By: Krinkle
Differential Revision: ​https://code.wildfiregames.com/D2649

Note: See TracTickets for help on using tickets.