Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#2552 closed task (fixed)

Upgrade miniupnpc to version 1.9

Reported by: Josh Owned by: historic_bruno
Priority: Should Have Milestone: Alpha 18
Component: Build & Packages Keywords:
Cc: leper Patch:

Description

We should update to the newer release of miniupnp to make it easier for linux package builders.

I've attached a patch for the only source change required on our side.

Attachments (2)

upgrade-miniupnpc.diff​ (457 bytes ) - added by Josh 9 years ago.
Source changes required
miniupnpc_api.patch​ (787 bytes ) - added by leper 9 years ago.
cleaned up diff

Download all attachments as: .zip

Change History (8)

by Josh, 9 years ago

Attachment: upgrade-miniupnpc.diff​ added

Source changes required

by leper, 9 years ago

Attachment: miniupnpc_api.patch​ added

cleaned up diff

comment:1 by leper, 9 years ago

In 15174:

Support newer version of miniupnpc api. Refs #2552.

comment:2 by Itms, 9 years ago

Milestone: Alpha 17 → Alpha 18

I suppose we won't make the update before A17, don't hesitate to correct me otherwise.

comment:3 by fabio, 9 years ago

This could follow the same treatment of enet: every Linux distribution I know of ships miniupnpc, so it could be removed forcing the use of system lib. No idea if it's really doable, however.

comment:4 by historic_bruno, 9 years ago

Owner: set to historic_bruno
Status: new → assigned

comment:5 by ben, 9 years ago

Resolution: → fixed
Status: assigned → closed

In 15870:

Removes bundled MiniUPnPc source, it is now a required system library on *nix. NOTE: update-workspaces must be run. See the updated BuildInstructions for details.
Adds precompiled MiniUPnPc 1.9 libs for win32, fixes #2552.
Updates build-osx-libs.sh for these changes, including patch to fix clang symbol visibility (fixed upstream).
Updates LICENSE.txt.
Fixes bug in build-osx-libs.sh where downloaded files might not have the expected filename.
Fixes problem with building wxWidgets for 32-bit OS X targets, apparently ARCH is ignored sometimes, but --enable-macosx_arch works.

comment:6 by leper, 9 years ago

In 15873:

Remove leftovers from bundled miniupnpc. Refs #2552.
Fix cleanup of SM24.

Note: See TracTickets for help on using tickets.