Changes between Initial Version and Version 1 of Ticket #2580, comment 1


Ignore:
Timestamp:
May 22, 2014, 4:13:59 AM (10 years ago)
Author:
historic_bruno

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2580, comment 1

    initial v1  
    44Indeed it is, thanks for reporting this! :)
    55
    6 I guess we are relying on the UI to prevent these cases. `Engine.PostNetworkCommand` is used by the GUI scripts directly to send commands, so we can't do anything about that, but we definitely shouldn't rely on it passing only valid/legal/correct commands. The proposed checks should go in `Commands.js` or component helper functions it uses, if applicable.
     6I guess we are relying on the UI to prevent these cases. `Engine.PostNetworkCommand` is used by the GUI scripts directly to send commands, so we can't do anything about that, but we definitely shouldn't rely on it passing only valid/legal/correct commands. The proposed checks should go in [source:/ps/trunk/binaries/data/mods/public/simulation/helpers/Commands.js Commands.js] or component helper functions it uses, if applicable.
    77
    88Please let us know if you find any more.