3rd macedinian war scenario gives an error in AuraManager

[mimo]

When trying to play this map on svn, there is an JS error just at startup

GAME STARTED, ALL INIT COMPLETE

WARNING: JavaScript warning: simulation/components/AuraManager.js line 133 reference to undefined property this.modificationsCache[valueName][ent] ERROR: JavaScript error: simulation/components/AuraManager.js line 133 TypeError: this.modificationsCache[valueName][ent] is undefined

AuraManager.prototype.ApplyModifications@simulation/components/AuraManager.js:133 ApplyValueModificationsToEntity@simulation/helpers/ValueModification.js:14 Attack.prototype.GetAttackStrengths/applyMods@simulation/components/Attack.js:369 Attack.prototype.GetAttackStrengths@simulation/components/Attack.js:373 GuiInterface.prototype.GetExtendedEntityState@simulation/components/GuiInterface.js:360 GuiInterface.prototype.ScriptCall@simulation/components/GuiInterface.js:1978

ERROR: Error calling component script function ScriptCall WARNING: JavaScript warning: gui/session/session.js line 642 reference to undefined property heroState.armour

[sanderd17]

This is not our issue, but a bug in spidermonkey. See ​https://bugzilla.mozilla.org/show_bug.cgi?id=991457 for the bug report there.

It's fixed upstream, but we'll only get the fix when we update to v31.

[mimo]

Pushing to A18 as it needs spidermonkey v31

[Yves]

In 16214:

SpiderMonkey 31 upgrade

This upgrade also introduces exact stack rooting (see to the wiki: JSRootingGuide) and fixes problems with moving GC. This allows us to enable generational garbage collection (GGC).
Measurements a few months ago have shown a performance improvement of a non-visual replay of around 13.5%. This probably varies quite a bit, but it should be somewhere between 5-20%. Memory usage has also been improved. Check the forum thread for details.

Thanks to everyone from the team who helped with this directly or indirectly (review, finding and fixing issues, the required C++11 upgrade, the new autobuilder etc.)! Also thanks to the SpiderMonkey developers who helped on the #jsapi channel or elsewhere!

Fixes #2462, #2415, #2428, #2684, #1374
Refs #2973, #2669

[sanderd17]

In 16512:

Use Maps instead of Objects in the Auramanager to improve performance. Also remove the IonMonkey v24 workaround. Refs #2684