Changes between Initial Version and Version 1 of Ticket #2706


Ignore:
Timestamp:
Aug 5, 2014, 4:17:57 PM (5 years ago)
Author:
wraitii
Comment:

I have moved the "CanTransform?" check and the actual replacing to a Transform.js helper file, that Pack.js component also uses (and made the logic slightly better).

I think I've taken into account all of sanderd17 and leper's style remarks (except for the name of the component, I don't really see Transform as better than Upgrade as the most descriptive name would be ReplaceTemplate? or something).

I've added the ability to transfer the garrisoning but not the production queue yet.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2706 – Description

    initial v1  
    1515Attached patch also changes the "Long wall->Gate" transformation to use this system and removes obsolete code.
    1616
    17 As in #1919, this has some duplicate code with promotion. I think we should move the actual "replacing" code to a helper since it will be similar in #1919, promotion, and this patch. I think however the behavior of packing/unpacking is different enough from upgrading that it should be kept separate.
     17This patch implements a generic helper to replace entities' template which #1919 could use.