Changes between Initial Version and Version 3 of Ticket #2732


Ignore:
Timestamp:
Aug 18, 2014, 5:02:34 PM (10 years ago)
Author:
Radagast
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2732

    • Property Keywords review removed
    • Property Summary [Patch] Extend the Looter component to transfer any carried resources and garrisoned entities (aka Inventory transfer). → [PATCH] Looting carried ressources and handling of garrisoned entities

  • Ticket #2732 – Description

    initial v3  
    1212
    1313- Garrisoned entities are first being ejected, then the Ownership is transfered from the previous owner (enemy or ally thereof) to the looting unit's player, finally the unit is garrisoned inside the looting unit.
     14
     15
     16Edit as I'm always recognized as spam despite captcha.
     17'''@Itms:'''
     18Thank you Itms for the review, I agree.
     19
     20I added the review keyword too early. I currently try to learn how to best handle those versions and keeping track of the changes. To get some feedback I submitted this patch. And I got what I wanted. Thanks a lot.
     21
     22Once I have less trigger work and can resolve a strange git branching issue that somehow reloads my Looter.js twice (or perhaps I have to clear the cache), I will submit new versions (I have maintain a branch for each of my planned patches).
     23
     24Next I will split the two approaches and make it committable (removing all but the most needed comments).