Changes between Initial Version and Version 1 of Ticket #2749, comment 5


Ignore:
Timestamp:
May 3, 2015, 4:17:04 AM (9 years ago)
Author:
elexis

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #2749, comment 5

    initial v1  
    2424
    2525'''Open questions'''
    26 1. The code should be refactored and moved into a single component CeasefireManager, since StartCeasefire (in LoadPlayerSettings in the player component) and GetCeasefireTime (in GetSimulationState in GuiInterface) must be called for only one player (currently the last player).
     261. ~~The code should be refactored and moved into a single component CeasefireManager, since StartCeasefire (in LoadPlayerSettings in the player component) and GetCeasefireTime (in GetSimulationState in GuiInterface) must be called for only one player (currently the last player).~~ ''FIXED''
    27272. Why is displaying the chat notification ("You have declared war on player X") slow? They immediately start fighting after ceasefire ended, but the chat messages take a while.
    28283. This patch cleans some code in gamesetup.js for scenario maps. Maybe add a ceasefire option to atlas and let scenario maps determine the ceasefire timeout?
    29 
     294. Send a message when the ceasefire starts / ends? Maybe the AI can use it.
    3030
    3131This patch will fix #3195 too :-)