Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#2810 closed defect (fixed)

[PATCH] Race condition found in FCollada Makefile

Reported by: Guido Falsi Owned by: leper
Priority: Must Have Milestone: Alpha 17
Component: Build & Packages Keywords: fcollada patch
Cc: Patch:

Description (last modified by Guido Falsi)

While testing on FreeBSD I found a race condition in the fcollada Makefile:

all: output_dirs output/libFColladaSD.a output/libFColladaSR.a install

as it is there is no warranty the output_dirs target will be executed before the other ones or their descendants, so sometimes the build fails due to missing directories.

I fixed it with the attached patch, which adds output_dirs as an order only dependency on all relevant targets, warranting it will be executed first.

It fixed the probem for me.

Attachments (1)

patch-libraries__source__fcollada__src__Makefile​ (1.5 KB ) - added by Guido Falsi 10 years ago.
Race condition fix

Download all attachments as: .zip

Change History (6)

by Guido Falsi, 10 years ago

Attachment: patch-libraries__source__fcollada__src__Makefile​ added

Race condition fix

comment:1 by Guido Falsi, 10 years ago

Description: modified (diff)

comment:2 by Stan, 10 years ago

Keywords: review patch added

comment:3 by Guido Falsi, 10 years ago

Summary: Race condition found in FCollada Makefile → [PATCH] Race condition found in FCollada Makefile

comment:4 by leper, 10 years ago

Owner: set to leper
Resolution: → fixed
Status: new → closed

In 15794:

Fix race condition in FCollada Makefile. Patch by madpilot. Fixes #2810.

comment:5 by leper, 10 years ago

Keywords: review removed

Thanks for the patch.

Note: See TracTickets for help on using tickets.