#2825 closed enhancement (fixed)
[PATCH] Unify build.sh and build-osx-bundle.sh .po file code
| Reported by: | leper | Owned by: | leper |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | Alpha 17 |
| Component: | Build & Packages | Keywords: | patch |
| Cc: | Patch: |
Description
Both build.sh and build-osx-bundle.sh remove all .po files that aren't in a list (actually in a regex currently) and need to be kept in sync so that we have the same languages available on all platforms.
This isn't optimal and the attached patch should fix that issue.
Attachments (1)
Change History (6)
by , 10 years ago
| Attachment: | dist_langs.diff added |
|---|
comment:1 by , 10 years ago
comment:3 by , 10 years ago
| Keywords: | patch review added |
|---|---|
| Summary: | Unify build.sh and build-osx-bundle.sh .po file code → [PATCH] Unify build.sh and build-osx-bundle.sh .po file code |
Seems to work, though I don't understand why the l10n.sh script is called with a dot? Is that to avoid the script having executable permission?
comment:4 by , 10 years ago
Agreed about the name, something like remove-incomplete-translations.sh would be better.
It's just sourcing the script there (in bash we could use source, but . is more common), so we don't have to call another instance of the shell and remove the need for the file to be executable. (Also prevents users from inexpectedly executing the file).
comment:6 by , 10 years ago
| Keywords: | review removed |
|---|
I would name it something other than
l10n.sh, since it deletes files and there is a chance someone runs it without knowing what it does. I will try to test the patch on OS X later today.