Opened 8 years ago

Closed 2 years ago

#2846 closed defect (fixed)

SDL2: Atlas text input broken

Reported by: historic_bruno Owned by: wraitii
Priority: Nice to Have Milestone: Alpha 24
Component: Atlas editor Keywords:
Cc: Patch: Phab:D2788

Description

Atlas uses wxWidgets to handle input, so it pumps simulated SDL events into the engine. With SDL1, it would use the "unicode" field of SDL_keysym for text input, but SDL2 completely changed how text input works. Now we'll need to simulate SDL_TextEditingEvents.

Change History (2)

comment:1 by wraitii, 2 years ago

Milestone: BacklogAlpha 24
Owner: set to wraitii
Patch: Phab:D2788

comment:2 by wraitii, 2 years ago

Resolution: fixed
Status: newclosed

In 23926:

Fix issues relating to SDL and wxWidgets interaction in Atlas.

This fixes the transfer of key inputs from WxWidgets to SDL, making it possible to type in the in-game GUI from Atlas.

Also fixes whitespace issues in some Atlas files.

The following improvements are OSX specific:

  • fixes an SDL assertion related to unused subsystems in Atlas.
  • Remove the 'osxguiapplication' override. This fixes the editor starting up in the background and not accepting input when launched from in-game.
  • To prevent an issue with sdl/wxwidgets conflict when running from inside the game, actually boot a new instance (see #2427)

Reported by: wik (Many thanks for your investigations)

Tested by: trompetin17, Stan

Fixes #2427
Fixes #2846

Differential Revision: https://code.wildfiregames.com/D2788

Note: See TracTickets for help on using tickets.