Opened 9 years ago

Closed 9 years ago

Last modified 5 years ago

#2891 closed enhancement (fixed)

Switch to wxWidgets 3 on Windows

Reported by: Yves Owned by:
Priority: Should Have Milestone: Alpha 18
Component: Atlas editor Keywords: wxWidgets
Cc: historic_bruno, tjh.hts@… Patch:

Description

Are there any reasons we are still using wxWdigets 2.8 on Windows? WxWidgets 3 is easier to build on Windows because it already ships Visual Studio projects and some manual adjustments aren't required anymore. I've successfully build Atlas using wxWidgets 3 on the new autobuild server. Only a few minor changes were required (patch attached, also updating the README.txt).

Attachments (1)

wxWidgets30_Win_v1.diff (2.1 KB ) - added by Yves 9 years ago.

Download all attachments as: .zip

Change History (8)

by Yves, 9 years ago

Attachment: wxWidgets30_Win_v1.diff added

comment:1 by Yves, 9 years ago

Cc: historic_bruno added

comment:2 by Niek, 9 years ago

Summary: Switch to wxWdigets 3 on WindowsSwitch to wxWidgets 3 on Windows

comment:3 by Timothy Hamlett, 9 years ago

Cc: tjh.hts@… added

comment:4 by historic_bruno, 9 years ago

When testing wxWidgets 3.0, I've noticed the game won't build except with the same version of MSVC as used to build wxWidgets (due to linker errors). This wasn't a problem in wwWidgets 2.8, but it complicates things if we want to offer a prebuilt wxWidgets in the future. It seems in include/msvc/wx/setup.h there's a way to set it up to use version-specific lib directories e.g. vc100_lib instead of vc_lib.

I also noticed it builds without specifying the lib names in extern_libs4.lua, since setup.h already includes the needed libraries.

Aside from build issues, we just need to test carefully, there have been several reports of bugs in the game caused by earlier wxWidgets 3.0 releases.

comment:5 by Yves, 9 years ago

In 16139:

Don't specify wxwidgets lib names in extern_libs4.lua

It works without specifying them and this way it builds with wxwidgets 2.8 and 3 on Windows

Refs #2891

comment:6 by historic_bruno, 9 years ago

Resolution: fixed
Status: newclosed

Fixed with the new autobuilder using wxWidgets 3.0.2.

comment:7 by historic_bruno, 5 years ago

In 22508:

Makes wxWidgets 3.0 dependency explicit in the game build.
Removes a few non-behavioral workarounds for older versions.

Refs #5502, #2891.
Accepted By: asterix
Comments by: vladislavbelov
Differential Revision: https://code.wildfiregames.com/D2076

Note: See TracTickets for help on using tickets.