[PATCH] Use nested repeat tags in the summary screen xml

[leper]

r16034 added nested repeat tags (see the repeat GUI object documentation for an example). The summary screen (binaries/data/mods/public/gui/summary.xml is using similar object names because that support was missing previously.

Those objects can now be changed to have multiple nested repeats to make the xml file a lot more readable. The summary.js file will need some changes so that the names are properly constructed.

[leper]

There are still countless duplicate elements (teamBox, etc) that should be moved and sized by the js and use one object with a few others below it.

[trompetin17]

Done, this new patch only use one panel container, I added two js helpers.

Let me know what do you think about it.

tested with:

• No team
• All teams
• One without team
• Compared with the old one

Replying to leper:

There are still countless duplicate elements (teamBox, etc) that should be moved and sized by the js and use one object with a few others below it.

[trompetin17]

Fixed itms :)

[Itms]

Hello trompetin, I am sorry but there is one problem I had not thought of: you call translate(headings[h].caption);, which won't work.

The message extraction will not detect the strings in panelsData as translatable data. So you have to write things like "caption": translate("Player name") in panelsData and then directly write things like headerGUI.caption = headings[h].caption;.

Sorry for the oversight!

[trompetin17]

I tested in my local enviroment, and it is translate, could we chat about it on IRC when you have time please? Replying to Itms:

Hello trompetin, I am sorry but there is one problem I had not thought of: you call translate(headings[h].caption);, which won't work.

The message extraction will not detect the strings in panelsData as translatable data. So you have to write things like "caption": translate("Player name") in panelsData and then directly write things like headerGUI.caption = headings[h].caption;.

Sorry for the oversight!

[Itms]

I can't connect right now, I'll be there in an hour or so. You should read wiki:Internationalization in the meantime, to understand the problem.

[trompetin17]

Don´t worry, leper help me about it :), now I guess I got it, I updated the patch

Replying to Itms:

I can't connect right now, I'll be there in an hour or so. You should read wiki:Internationalization in the meantime, to understand the problem.

[Itms]

In 16240:

Big cleanup of the summary page internals, making use of nested tags in the xml and organizing the logic in a more flexible way.

Patch by trompetin17, fixes #2952.

[Itms]

Thanks a lot for this great patch!