Opened 5 years ago

Last modified 3 months ago

#2988 assigned enhancement

[PATCH] Improve performance Object List Filter Atlas

Reported by: trompetin17 Owned by: trompetin17
Priority: Should Have Milestone: Backlog
Component: Atlas editor Keywords: patch
Cc: Patch: Phab:D2040

Description

this patch change wxListbox for wxListView, and change hardcode loop(vector iterator) for std::for_each

Attachments (1)

2988.diff (5.6 KB) - added by trompetin17 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by trompetin17

Attachment: 2988.diff added

comment:1 Changed 5 years ago by trompetin17

Owner: set to trompetin17
Status: newassigned
Summary: Improve performance Object List Filter Atlas[PATCH] Improve performance Object List Filter Atlas

comment:2 Changed 5 years ago by historic_bruno

Replacing wxListbox with wxListView seems like it might be a good idea. I'm not sure about the filter function redesign though, is that really more efficient? It looks much less readable to me and the g_itemIdListView global variable is yucky.

comment:3 Changed 5 years ago by historic_bruno

Keywords: Atlas review removed

comment:4 Changed 5 years ago by Itms

Milestone: Alpha 18Alpha 19

Pushing after IRC discussion.

comment:5 Changed 4 years ago by Itms

Milestone: Alpha 19Alpha 20

comment:6 Changed 4 years ago by elexis

Milestone: Alpha 20Backlog

comment:7 Changed 3 months ago by trompetin17

Patch: Phab:D2040

comment:8 Changed 3 months ago by trompetin17

Change the way I filtered the list

Note: See TracTickets for help on using tickets.