Opened 6 years ago

Closed 4 years ago

Last modified 3 years ago

#3039 closed defect (fixed)

SpiderMonkey 31 compilation error with Ubuntu PPA

Reported by: scythetwirler Owned by: scythetwirler
Priority: Should Have Milestone: Alpha 21
Component: Build & Packages Keywords:
Cc: Yves Patch:

Description (last modified by temple)

Compiling with the --with-system-mozjs31 flag gives the following error:

#error Your compiler is trying to use an untested minor version of the \ SpiderMonkey library. If you are a package maintainer, please make sure \ to check very carefully that this version does not change the behaviour \ of the code executed by SpiderMonkey. Different parts of the game (e.g. \ the multiplayer mode) rely on deterministic behaviour of the JavaScript \ engine. A simple way for testing this would be playing a network game \ with one player using the old version and one player using the new \ version. Another way for testing is running replays and comparing the \ final hash (check trac.wildfiregames.com/wiki/Debugging#Replaymode). \ For more information check this link: trac.wildfiregames.com/wiki/Debugging#Outofsync

libmozjs-31-dev: Installed: 31.4~hg20150203.esr31.364c5c12-0ubuntu1~14.04~wfg0 Candidate: 31.4~hg20150203.esr31.364c5c12-0ubuntu1~14.04~wfg0 Version table: * 31.4~hg20150203.esr31.364c5c12-0ubuntu1~14.04~wfg0 0 500 http://ppa.launchpad.net/wfg/0ad.dev/ubuntu/ trusty/main amd64 Packages

Change History (6)

comment:1 by scythetwirler, 6 years ago

Cc: Yves added

Changing line 89 of source/scriptinterface/ScriptTypes.h from #if MOZJS_MINOR_VERSION != 2 to #if MOZJS_MINOR_VERSION != 4 will fix this issue, but I'm not sure of the implications.

comment:2 by scythetwirler, 6 years ago

Owner: set to scythetwirler
Resolution: fixed
Status: newclosed

In 16283:

Fixes build with libmozjs-31-dev package from Ubuntu PPA. Fixes #3039.

Seems like there's no OOS between those two minor revisions.

Last edited 6 years ago by scythetwirler (previous) (diff)

comment:3 by fabio, 6 years ago

BTW, if there are useful improvements in 31.4, it would be nice to upgrade also the bundled version.

comment:4 by NickKolok, 4 years ago

Milestone: Alpha 18Alpha 21
Priority: Must HaveShould Have
Resolution: fixed
Status: closedreopened

Greeting from Russia, comrads!

The bug appears again, with libmozjs-31-dev version 31.5.0-0ubuntu1~12.04~wfg2. The solution is similar. Maybe it is a good idea not to update this package in PPA? Maybe bumping libmozjs version can be automatically tested?

comment:5 by fabio, 4 years ago

Resolution: fixed
Status: reopenedclosed

In 18153:

Support building with mozjs 31.5 used in Ubuntu PPA.
Fixes #3039.

comment:6 by temple, 3 years ago

Description: modified (diff)

With mozjs 38.8 I had to add MOZJS_MINOR_VERSION != 8 as well as undo the changes in r18678.

Note: See TracTickets for help on using tickets.