Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#3040 closed defect (fixed)

[PATCH] Only send game reports if the game is actually rated

Reported by: leper Owned by: elexis
Priority: Should Have Milestone: Alpha 21
Component: Multiplayer lobby Keywords: patch
Cc: Patch:

Description

Currently we send game reports for lobby games for every lobby game. This should only be done for rated games.

To make the rating system extendable the clients should ask the bot if the current game is rated (possibly at the start of the game) and only in this case send the game report.

Attachments (1)

less_lobby_updates_v1.patch (726 bytes ) - added by elexis 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by elexis, 8 years ago

Looking at session.js, this seems to be the case already:

function reportGame()
{
	if (!Engine.HasXmppClient() || !Engine.IsRankedGame())
		return;

But I guess we could also early-return in case numPlayers != 2.

Why would we have to contact the lobbybot to findout if its rated?

by elexis, 8 years ago

Attachment: less_lobby_updates_v1.patch added

comment:2 by elexis, 8 years ago

Keywords: patch review added
Milestone: BacklogAlpha 21
Summary: Only send game reports if the game is actually rated[PATCH] Only send game reports if the game is actually rated

comment:3 by elexis, 8 years ago

Owner: set to elexis
Resolution: fixed
Status: newclosed

In 18018:

Only send a gamereport to the lobbybot for 1v1s (as only those are rated), fixes #3040.

comment:4 by elexis, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.