Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#3051 closed enhancement (fixed)

[PATCH] Allow the removal of hotkeys

Reported by: elexis Owned by: sanderd17
Priority: Must Have Milestone: Alpha 21
Component: Core engine Keywords: patch
Cc: Patch:

Description (last modified by elexis)

Problem: If one uses Alt+DoubleClick to select all units of the same kind, WASD to scroll and also experiences this bug ​http://trac.wildfiregames.com/ticket/2809 it is likely that the shortcut Alt+D = developer console will be triggered and people think that one cheats.

Thats why I decided to delete this shortcut by assigning it to an empty string in local.cfg. (​http://trac.wildfiregames.com/wiki/Manual_Settings)

With this config an error message is triggered unnecessarily.

This patch removes the error message.

Attachments (3)

patch​ (549 bytes ) - added by elexis 9 years ago.
3051_unused_hotkeys.patch​ (463 bytes ) - added by Imarok 8 years ago.
Allowing unused as hotkey(caseinsensitive)
3051_unused_hotkeys_v2.patch​ (503 bytes ) - added by Imarok 8 years ago.
moved the if one for higher

Download all attachments as: .zip

Change History (21)

by elexis, 9 years ago

Attachment: patch​ added

comment:1 by elexis, 9 years ago

Keywords: review patch added

comment:2 by elexis, 9 years ago

Description: modified (diff)

comment:3 by elexis, 9 years ago

Summary: Allow the removal of keyboard shortcuts → [PATCH] Allow the removal of keyboard shortcuts

comment:4 by elexis, 9 years ago

Description: modified (diff)
Milestone: Alpha 18 → Alpha 19
Summary: [PATCH] Allow the removal of keyboard shortcuts → Allow the removal of keyboard shortcuts

review patch

comment:5 by elexis, 9 years ago

The patch above removes the warning message - however it doesn't remove the keyboard shortcut.

Until the feature is implemented, one can assign the unwanted shortcut to a key that is not on the keyboard (for example F13 on most keyboard layouts).

Other supported keys are found in [​​http://svn.wildfiregames.com/public/ps/trunk/source/ps/KeyName.cpp]

comment:6 by leper, 9 years ago

Keywords: review removed

As noted on irc already, the above patch does not fix the issue at all, it just removes the warning.

comment:7 by historic_bruno, 9 years ago

Milestone: Alpha 19 → Backlog

comment:8 by elexis, 8 years ago

Keywords: simple added
Priority: Nice to Have → Must Have
Summary: Allow the removal of keyboard shortcuts → Allow the removal of hotkeys

Totally needed since there will be many more hotkeys added (f.e. #1899) and it should be easily possible to nuke them.

See also #3990.

comment:9 by elexis, 8 years ago

In 18253:

Properly handle the case of removed hotkeys in r18252, refs #3051.

comment:10 by apushkar, 8 years ago

Maybe it would be better to enable developer stuffs within special menu or with using of executable parameter?

by Imarok, 8 years ago

Attachment: 3051_unused_hotkeys.patch​ added

Allowing unused as hotkey(caseinsensitive)

comment:11 by Imarok, 8 years ago

Keywords: review added
Milestone: Backlog → Alpha 21
Summary: Allow the removal of hotkeys → [PATCH] Allow the removal of hotkeys

comment:12 by sanderd17, 8 years ago

Keywords: rfc added; review removed

AFAICS, the added code is in the wrong for loop, it would be more correct to have it before tokenizing the hotkey I guess.

by Imarok, 8 years ago

Attachment: 3051_unused_hotkeys_v2.patch​ added

moved the if one for higher

comment:13 by Imarok, 8 years ago

Keywords: review added; rfc removed

comment:14 by sanderd17, 8 years ago

I tested it, and it works. The code looks good too.

comment:15 by sanderd17, 8 years ago

Owner: set to sanderd17
Resolution: → fixed
Status: new → closed

In 18565:

Allow to set 'unused' as a hotkey to disable that action. Patch by Imarok. Fixes #3051

comment:16 by sanderd17, 8 years ago

Keywords: review removed

comment:17 by elexis, 8 years ago

In 18570:

Hide unassigned hotkeys. Patch by Imarok, refs #3051.

comment:18 by elexis, 8 years ago

Keywords: simple removed

Thanks for the patches!

Note: See TracTickets for help on using tickets.