Opened 3 years ago

Closed 16 months ago

Last modified 16 months ago

#3051 closed enhancement (fixed)

[PATCH] Allow the removal of hotkeys

Reported by: elexis Owned by: sanderd17
Priority: Must Have Milestone: Alpha 21
Component: Core engine Keywords: patch
Cc: Patch:

Description (last modified by elexis)

Problem: If one uses Alt+DoubleClick? to select all units of the same kind, WASD to scroll and also experiences this bug http://trac.wildfiregames.com/ticket/2809 it is likely that the shortcut Alt+D = developer console will be triggered and people think that one cheats.

Thats why I decided to delete this shortcut by assigning it to an empty string in local.cfg. (http://trac.wildfiregames.com/wiki/Manual_Settings)

With this config an error message is triggered unnecessarily.

This patch removes the error message.

Attachments (3)

patch (549 bytes) - added by elexis 3 years ago.
3051_unused_hotkeys.patch (463 bytes) - added by Imarok 16 months ago.
Allowing unused as hotkey(caseinsensitive)
3051_unused_hotkeys_v2.patch (503 bytes) - added by Imarok 16 months ago.
moved the if one for higher

Download all attachments as: .zip

Change History (21)

Changed 3 years ago by elexis

Attachment: patch added

comment:1 Changed 3 years ago by elexis

Keywords: review patch added

comment:2 Changed 3 years ago by elexis

Description: modified (diff)

comment:3 Changed 3 years ago by elexis

Summary: Allow the removal of keyboard shortcuts[PATCH] Allow the removal of keyboard shortcuts

comment:4 Changed 3 years ago by elexis

Description: modified (diff)
Milestone: Alpha 18Alpha 19
Summary: [PATCH] Allow the removal of keyboard shortcutsAllow the removal of keyboard shortcuts

review patch

comment:5 Changed 3 years ago by elexis

The patch above removes the warning message - however it doesn't remove the keyboard shortcut.

Until the feature is implemented, one can assign the unwanted shortcut to a key that is not on the keyboard (for example F13 on most keyboard layouts).

Other supported keys are found in [​http://svn.wildfiregames.com/public/ps/trunk/source/ps/KeyName.cpp]

comment:6 Changed 3 years ago by leper

Keywords: review removed

As noted on irc already, the above patch does not fix the issue at all, it just removes the warning.

comment:7 Changed 3 years ago by Ben Brian

Milestone: Alpha 19Backlog

comment:8 Changed 18 months ago by elexis

Keywords: simple added
Priority: Nice to HaveMust Have
Summary: Allow the removal of keyboard shortcutsAllow the removal of hotkeys

Totally needed since there will be many more hotkeys added (f.e. #1899) and it should be easily possible to nuke them.

See also #3990.

comment:9 Changed 18 months ago by elexis

In 18253:

Properly handle the case of removed hotkeys in r18252, refs #3051.

comment:10 Changed 17 months ago by apushkar

Maybe it would be better to enable developer stuffs within special menu or with using of executable parameter?

Changed 16 months ago by Imarok

Attachment: 3051_unused_hotkeys.patch added

Allowing unused as hotkey(caseinsensitive)

comment:11 Changed 16 months ago by Imarok

Keywords: review added
Milestone: BacklogAlpha 21
Summary: Allow the removal of hotkeys[PATCH] Allow the removal of hotkeys

comment:12 Changed 16 months ago by sanderd17

Keywords: rfc added; review removed

AFAICS, the added code is in the wrong for loop, it would be more correct to have it before tokenizing the hotkey I guess.

Changed 16 months ago by Imarok

moved the if one for higher

comment:13 Changed 16 months ago by Imarok

Keywords: review added; rfc removed

comment:14 Changed 16 months ago by sanderd17

I tested it, and it works. The code looks good too.

comment:15 Changed 16 months ago by sanderd17

Owner: set to sanderd17
Resolution: fixed
Status: newclosed

In 18565:

Allow to set 'unused' as a hotkey to disable that action. Patch by Imarok. Fixes #3051

comment:16 Changed 16 months ago by sanderd17

Keywords: review removed

comment:17 Changed 16 months ago by elexis

In 18570:

Hide unassigned hotkeys. Patch by Imarok, refs #3051.

comment:18 Changed 16 months ago by elexis

Keywords: simple removed

Thanks for the patches!

Note: See TracTickets for help on using tickets.