Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3059 closed defect (fixed)

[PATCH] wooden tower (aka palisade fort) needs some cleanup

Reported by: mimo Owned by: Stan
Priority: Nice to Have Milestone: Alpha 19
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

Wooden towers have been added in A18, but they would need some cleanup:

  • template (other/palisades_rocks_fort) should be moved to the standard place, with possibly one template per civ (removing the gaia civ from the template)
  • a garrison flag should be added

and personally, I find them a bit too powerful for a village phase structure. Possible changes would be:

  • decrease the garrison capacity from 5 to 3
  • remove the techs which anyway cannot be researched before town phase (such that a defense tower is still necessary for researching these techs, although the techs would still apply to wooden tower as now).

Attachments (5)

woodenTower.diff (12.6 KB ) - added by mimo 9 years ago.
3059.diff (426.2 KB ) - added by Stan 9 years ago.
Add a flag for each civ, hellenes and celts use the same flag respectively cause they don't have their own.
palisade_rocks_fort_ao.png (517.7 KB ) - added by Stan 9 years ago.
The ambien occlusion file
3059.1.diff (422.0 KB ) - added by Stan 9 years ago.
Simple version.
3059.2.diff (424.2 KB ) - added by Stan 9 years ago.
Sorry correct version.

Download all attachments as: .zip

Change History (22)

comment:1 by Lionkanzen, 9 years ago

Change the cost, actually are the same as a tower. Change the limit by meters/ distance to less meter or limit by numbers

comment:2 by Stan, 9 years ago

@mimo :

  • What does Scythe think about the balance changes you propose ?
  • Adding a garrison flag, is easy (for me at least), but that require Enrique to check it, right ?
  • Would it ten templates ten actors, or one template ten actors (You need ten for the garrison flags).
Last edited 9 years ago by Stan (previous) (diff)

comment:3 by mimo, 9 years ago

Yes, I think Scythe and Enrique are not available these days, but that should not prevent us from doing the changes needed.

Here is the patch I had in mind, the balance changes are minor: mainly limiting the garrison to 3 instead of 5, but allowing the attack_tower_watch in village phase and removing the other techs which are anyway not available before town phase (when researched from a defense_town, they will nonetheless apply to wooden towers as now). In addition, having the same capturePoints than a defense_tower (1000) was not consistent, so it is decreased a bit to 800.

As you see, there is one template for each civ (to allow future differentiation). Only adding a garrison flag is a minor change and can be commited without a green light from the art department. :-)

The patch is just done this way to ease the diff of the changes I've done to the wooden tower template. In the final commit, the template_structure_defense_wooden_tower.xml and the other/palisades_rocks_fort.xml would be exchanged.

by mimo, 9 years ago

Attachment: woodenTower.diff added

comment:4 by mimo, 9 years ago

Keywords: patch review added
Summary: wooden tower (aka palisade fort) needs some cleanup[PATCH] wooden tower (aka palisade fort) needs some cleanup

comment:5 by Stan, 9 years ago

I see. But so after this patch, we will just have to add the <actor> tag to define one actor for each civ in order to have proper banners. This is gonna be a lot of replicated code though... Since instead of one special/wooden_tower.Xml we will have wooden_tower_spart, wooden_tower_athen etc...

Why did you remove the obstruction ? Is it for the new pathfinder ?

comment:6 by mimo, 9 years ago

This duplication is necessary as the goal of the changes is not only to add the garrison flag, but also to give the possibility for artists to provide a different model for each civ, or for "balancers" to play with different stats for each civ.

Concerning the obstruction, that was not wanted and I'll add it back.

comment:7 by mimo, 9 years ago

In 16878:

make a wooden tower template for each civ, refs #3059

comment:8 by mimo, 9 years ago

we still need to add the garrison flags before closing this ticket.

comment:9 by Stan, 9 years ago

Keywords: patch review removed
Owner: set to Stan

I'm on it.

by Stan, 9 years ago

Attachment: 3059.diff added

Add a flag for each civ, hellenes and celts use the same flag respectively cause they don't have their own.

comment:10 by Stan, 9 years ago

I also added, bump spec and ao map, and fixed some faces on the tower. I might suggest to also include this patch of mine :

http://wildfiregames.com/forum/index.php?showtopic=19043

comment:11 by Stan, 9 years ago

Keywords: review patch added

comment:12 by mimo, 9 years ago

The patch does not apply cleanly as palisade_rocks_fort_ao.png is missing (it should be uploaded somewhere).

But as I'm completely unqualified for all graphics changes, I can commit a patch only if you provide one with only the addition of the garrison flags, keeping all graphics improvment for an other ticket.

by Stan, 9 years ago

Attachment: palisade_rocks_fort_ao.png added

The ambien occlusion file

comment:13 by Stan, 9 years ago

Damn I though it would be included in the patch...

Also, it's just loading textures that currently exists, except from the AO.

Do you want a version without those ?

comment:14 by mimo, 9 years ago

Yes, I would prefer a simple patch that allow to close this ticket, and opening a new ticket with your improvements. I'm really not familiar with these changes, and have no time now to check if everything is fine.

by Stan, 9 years ago

Attachment: 3059.1.diff added

Simple version.

by Stan, 9 years ago

Attachment: 3059.2.diff added

Sorry correct version.

comment:15 by mimo, 9 years ago

Resolution: fixed
Status: newclosed

In 16889:

add garrison flag for wooden tower, patch from stanislas69, fixes #3059

comment:16 by mimo, 9 years ago

Keywords: review removed

Thanks for the patch.

comment:17 by Stan, 9 years ago

A pleasure to help. If you need anything on such matters, I'm here to help.

Note: See TracTickets for help on using tickets.