[PATCH] Cleanup Summary Screen

[Josh]

No text or code changes, just minor layout. Before: After:

[Josh]

Summary page after

[Josh]

Summary page before

[Itms]

Oh yeah, looks really good!

[exdeus]

Sweet improvement !

[Josh]

I'll commit this later today if there are no objections.

[JoshuaJB]

In 16384:

Cleanup post-game summary page. Fixes #3072

[elexis]

Patch doesn't work for three of us playing r16384! (windows 7 + ubuntu). The font was not found (and had the default 12 size + black color formatting).

[Niek]

I'm getting another error on the summary screen:

ERROR: GUI: Trying to use style 'TitleText' that doesn't exist.
ERROR: JavaScript error: fpsCounter tick line 1 ReferenceError: updateFPS is not defined __eventhandler177 (tick)@fpsCounter tick:1:5

[elexis]

yes, had that error too

[leper]

In 16385:

Revert r16384. Refs #3072.

[JoshuaJB]

In 16391:

Cleanup post-game summary page again. Fixes #3072

[leper]

In 16406:

Revert r16391. Refs #3072.

[leper]

Testing stuff would be nice. Tooltips for civ icons are broken and we're in commit freeze now (and were in feature freeze before).

[Josh]

Fixed again, but this time with more testing.

[elexis]

I experienced an error when playing r16699 and when hovering over the civ icon in the summary screen:

ERROR: Cannot find tooltip object named 'sessionToolTip'

The patch above includes common/gamesetup.xml again, which was removed in r16384 and r16391. That file is needed because it defines 'sessionToolTip'.

common/gamesetup.xml is included in all those following files except page_summary.xml:

page_civinfo.xml
page_gamesetup_mp.xml
page_gamesetup.xml
page_loadgame.xml
page_loading.xml
page_pregame.xml
page_savegame.xml
page_session.xml

leper could confirm this issue - we can't reproduce the error though. It is strange that this bug only occurs sometimes. The common/setup.xml file is probably included by another page that is active in the background if the bug doesn't occur.

[Josh]

It should just use ModernTooltip. We're trying to get rid of all the common references that are not modern.

[gameboy]

This error appears again.

[leper]

Using one of the modern tooltips (pg*) ends up with errors about missing gui objects, so something is broken here. (elexis' patch doesn't fix all errors)

[elexis]

Reproduce: When I start the game with -visual-replay (in my case with this commands.txt file: attachment:commands.2.txt:ticket:3221​) and exit to the summary screen, the error appears consistently when hovering the civ icon.

[JoshuaJB]

In 16831:

Fix #3072

[Josh]

The Modern style system has a default tooltip style which the engine will fall back on in the case of no specified style. I just had to remove the sessionToolTip reference and it was fixed.

[elexis]

Works (at least for the replay, couldn't reproduce the issue ingame), thank you!