[PATCH] Provide information about carried resources of a selection

[Kalle Richter]

It'd be nice to be an overview of which resources (and eventually how much of it) is carried in sum by a selection of units. This would serve to avoid sending a group of units carrying a valuable amount of resources of one type to collect another type and thus dropping the carried resources.

[mimo]

You already have that info in the tooltips of the unit icons of the central panel. I don't know if that is what you wanted, or if this ticket is specifically to add the sum on the different groups ? which I'm not sure it is that useful :-)

[Imarok]

Shows the carried resources of the whole selection as a tooltip of the total number of units in the selection

[Imarok]

used BARTER_RESOURCES instead of defining it again

[Imarok]

Now using RESOURCES

[Imarok]

removed one parenthesis

[elexis]

• As getCostComponentDisplayName returns an icon, then concatenation is ok with i != 3.
• You copy & pasted that code from selection_panels.js. Better move that code to a function and use that.
• getCostComponentDisplayName should be renamed, as it returns an icon, not names. Can be done in a separate commit.

[Lionkanzen]

Talk me if you need a new icon, guys.

[elexis]

Replying to Lionkanzen:

Talk me if you need a new icon, guys.

Completely unrelated, but the fishing net was discussed to get a new icon (the one that looks like a spooky ghost). Might want to ask mimo / sanderd17 / forum about further opinion.

[Lionkanzen]

Replying to elexis:

Replying to Lionkanzen:

Talk me if you need a new icon, guys.

Completely unrelated, but the fishing net was discussed to get a new icon (the one that looks like a spooky ghost). Might want to ask mimo / sanderd17 / forum about further opinion.

Sorry, but I don't know if you guys needs a icons, for the description of the problem may be need symbol ( capacity symbol like a cart) isn't my intention Elexis bother anyone here. Ok this is the last time. And sorry too much.

[elexis]

No problem Lionkanzen! We appreciate your offers. Better ask and get rejected rather than not asking when we could actually use your help.

For this ticket we use the existing food / wood / metal / stone icons. I will ask mimo if we could use an improvement of ​http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/art/textures/ui/session/portraits/technologies/fishing_net.png

[sanderd17]

Small comment on the code: you should try to avoid relying on the knowledge that there are 4 resources, and they are called these 4 names. If we ever want to add or remove a resource, it will already be a PITA to search all the places where the names are used. So better not add new places like these.

[Imarok]

Replying to sanderd17:

Small comment on the code: you should try to avoid relying on the knowledge that there are 4 resources, and they are called these 4 names. If we ever want to add or remove a resource, it will already be a PITA to search all the places where the names are used. So better not add new places like these.

Where in the patch do I rely on the knowledge there are 4 resources?

[Imarok]

merged line 392 and 393

[Imarok]

Updated to the new revision

[elexis]

Please fix the second point of comment:6

[Imarok]

removed brackets

[Imarok]

Replying to elexis:

Please fix the second point of comment:6

I thought this should be done in a seperate comment

[Imarok]

I'll add it

[Imarok]

rename getCostComponentDisplayName to getCostComponentDisplayIcon

[elexis]

• 2 revisions changed that code, the patch doesn't apply anymore
• 369-372 can be merged into a single line using totalResourcesCarried[carrying.type] = (totalResourcesCarried[carrying.type] || 0) + carrying.amount
• the substr call is ugly and could be replaced with trim'. Better avoid adding that unneeded space in the first place and replace the whole loop, if and trimming with Object.keys(totalResourcesCarried).map(res => getCostComponentDisplayIcon(res) + totalResourcesCarried[res]).join(",")`
• this allows allows to init totalResourcesCarried to {} immediately and removing the if ( totalResourcesCarried) check
• .length !== 0 only needs != 0

[Imarok]

followed the suggestions of comment:17

[elexis]

In 18154:

Display the carried resources when selecting a group of units. Patch by Imarok, fixes #3113.
Shows the information for all selected units and for all units of a given type.
Rename g_CostDisplayNames to g_CostDisplayIcons.

[elexis]

Thanks for the patch. I changed few characters:

-whitespace around Object.keys -length != 0 -> length -str -> tooltip

Your code assumes there will be only one type of resource carried per unit. Since thats actually the case, likely won't change soon and if it would, it would be easy to identify by searching for resourceCarrying, it is acceptable.

[elexis]

In 18763:

Order the carried resources as usual. Patch by Imarok, refs #3113.