[PATCH] Display healing process of garrisoned units

[Kalle Richter]

It'd be nice to have a display of the health of garrisoned units which are healing and thus allow to monitor that healing process.

[Imarok]

Show a health bar for garrisoned units. Also replaced some var with let

[sanderd17]

There are some issues with this patch:

The unit_commands.js file should be agnostic of what the panels look like. So you shouldn't have to modify it at all (unless you're adding a panel, which isn't the case here).

You should probably read the comment at the start of selection_panels.js to see how it's used. In short, the addData adds data per button, so the ents you have there is only a list of the ents of that button.

Now, for this feature, I think the code would fit more in the selection_details.js file.

After that, there are some small remarks you may watch out for the next time:

• It would be nice to check the hp and max hp for non-nulliness. So do something like data.health += data.hitpoints || 0;
• Since ents is an array, you can use for..of
• The comment in the gui XML doesn't need an extra indentation level.

[Imarok]

Move the code of the health bar to selection_details

[sanderd17]

In 18094:

Display health bar for garrisoned units. Patch by Imarok. Fixes #3114