Copy & Paste need to paste two times to get correct contents

[elexis]

Most of the time I need to press ctrl+v two times to get the correct clipboard contents.

I open 0ad, get into the game lobby, enter some text, copy or cut it (ctrl+c or ctrl+x) and paste it (ctrl+v).

Result: It pasted no text. If I press ctrl+v again it pastes the correct text.

If I copy from another application, the pasted string is sometimes correct when pasting the first time.

[historic_bruno]

Which OS is this and which version of the game?

[elexis]

Im using ubuntu 14.10 with i3 window manager. I had this bug both on a17 and a18.

It were good if someone else could check if he/she has this problem too....

[elexis]

Also im using SDL 2.

[trompetin17]

I tested in osx yosemite and it worked ok

[elexis]

I compiled the current a19 / svn version with SDL1 and the bug occurs too.

[elexis]

Crashes appear now too the more I play with ctrl+c and ctrl+v. Happened in the setup of a hosted game too.

[elexis]

Fortunately the application prints debug messges!

For each ctrl+c:

sys_clipboard_set: <clipboard contents>

and for each ctrl+v:

clipboard_get: XGetWindowProperty succeeded, returning data
clipboard_get: data was: "<clipboard content>", type was 31, XA_STRING atom is 31

---

And the bug appears in the log as follows:

sys_clipboard_set: test2
clipboard_get: XGetWindowProperty succeeded, returning data
clipboard_get: data was: "test1", type was 31, XA_STRING atom is 31
clipboard_get: XGetWindowProperty succeeded, returning data
clipboard_get: data was: "test2", type was 31, XA_STRING atom is 31

So although the sys_clipboard_set function was called, the result of clipboard_get is not test2 but test1 in this case.

---

In fact I can copy text as often as I want - the first pasted string after copying text will always be the last pasted string [or empty string].

---

Last but not least my poor 0ad crashes frequently when copy/pasting with the following error:

X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  18 (X_ChangeProperty)
  Resource id in failed request:  0x1804c8e
  Serial number of failed request:  7494
  Current serial number in output stream:  7496
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  25 (X_SendEvent)
  Resource id in failed request:  0x1804c8e
  Serial number of failed request:  7495
  Current serial number in output stream:  7497

[elexis]

sys_clipboard_get is implemented for each operating system individually - thats why the bug might not occur on osx.

lib/sysdep/os/win/wclipboard.cpp:wchar_t* sys_clipboard_get()
lib/sysdep/os/android/android.cpp:wchar_t* sys_clipboard_get()
lib/sysdep/os/unix/x/x.cpp:wchar_t *sys_clipboard_get()
lib/sysdep/os/osx/osx.cpp:wchar_t* sys_clipboard_get()

Here is a link to the file with the function sys_clipboard_get in line 177, that probably contains the bug: ​http://svn.wildfiregames.com/public/ps/trunk/source/lib/sysdep/os/unix/x/x.cpp

Notice that the application always reaches the "XGetWindowProperty succeeded, returning data" part, but with wrong data received by the XGetWindowProperty call the first time.

[elexis]

A buddy using ubuntu 14 is experiencing the same bug.

[temple]

Also on Ubuntu, experiencing the same bugs. When trying to copy something in the in-game chat window (rather than the lobby) the game almost always crashes.

[Stan]

Fixed in rP23624 (Tested on Kubuntu 20.04)