Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3153 closed defect (fixed)

[PATCH] On nomad only seleucids have cavalry in the beginning

Reported by: elexis Owned by: leper
Priority: Should Have Milestone: Alpha 19
Component: Maps Keywords:
Cc: Patch:

Description

And that is because the author of the map assumed that there are always 5 kinds of starting entities and didn't loop over the last one, except by accident on seleucids, which only have 4 kinds of starting entities currently.

The affected loop:

for (var j = 1; j < 4; ++j)
ROMAN "StartEntities":
[
	{
		"Template": "structures/rome_civil_centre"
	},
	{
		"Template": "units/rome_support_female_citizen",
		"Count": 4
	},
	{
		"Template": "units/rome_infantry_swordsman_b",
		"Count": 2
	},		
	{
		"Template": "units/rome_infantry_javelinist_b",
		"Count": 2
	},
	{
		"Template": "units/rome_cavalry_spearman_b"
	}
],

SELEUCIDS
"StartEntities":
[
	{
		"Template": "structures/sele_civil_centre"
	},
	{
		"Template": "units/sele_support_female_citizen",
		"Count": 4
	},
	{
		"Template": "units/sele_infantry_spearman_2_b",
		"Count": 4
	},
	{
		"Template": "units/sele_cavalry_javelinist"
	}
],

Attachments (1)

fix_nomad_cav.patch (937 bytes ) - added by elexis 9 years ago.

Download all attachments as: .zip

Change History (3)

by elexis, 9 years ago

Attachment: fix_nomad_cav.patch added

comment:1 by leper, 9 years ago

Owner: set to leper
Resolution: fixed
Status: newclosed

In 16477:

Add all non-structure starting entities to Unknown Nomad. Patch by elexis. Fixes #3153.

comment:2 by leper, 9 years ago

Component: Core engineMaps
Keywords: review removed
Priority: Must HaveShould Have

Thanks for the patch.

Note: See TracTickets for help on using tickets.