[PATCH] Lobby: Spam filter hides chat scrollback partially

[elexis]

When connecting to the multiplayer lobby, one receives a scrollback of the last 20 or so messages.

Unfortunately it doesn't display all messages in the scrollback, since the spam check filters out the last messages.

All scrollback messages are received OnTick() and all messages are posted into the addChatMessage function in lobby.js, where they are filtered out consequently according to the rules.

It should be fixed by disabling spam check until the scrollback was received completely.

It seems the last message in the scrollback is always the room message, i.e. :

"leper has set the subject to: This is the SVN lobby, if you don't know what this means, you should install the Alpha release."

[elexis]

Tested - chat scrollback shows up completely and spam after that is still filtered out.

[elexis]

I think this might also be the reason why one sometimes gets instantly spamblocked for 30 seconds after rejoining the lobby.

[Josh]

It would be better for the engine to add an attribute to the message containing information about what time a message was sent and whether or not it's part of the system history.

[Josh]

Disable the spam monitor while parsing historical data, fix timestamps on historical messages, and fix superfluous initial join messages.

[JoshuaJB]

In 16507:

Fix a number of issues related to historical messages and initial join in the multiplayer lobby. Fixes #3156

[elexis]

In 20776:

Support both DateTime formats of XEP-0082 in the lobby, refs #3156, rP16507, rP19801, rP20032.

Patch By: Dunedan
Fixes #4920.
Differential Revision: ​https://code.wildfiregames.com/D1197

[elexis]

In 22903:

Fix glooxwrapper::Message::when() memory leak in rP16507, refs #3156.

Differential Revision: ​https://code.wildfiregames.com/D2291
Tested on: clang 8.0.1