(De)serialisation fails on nested Map objects

[tom]

An error occurred loading the game, the game crashes. I tested 16528, the game fails to load a saved game, load game again after loading, the game crashes.

BTW: when I shut down the computer start your computer, start the game again loading the save game, the game crashes. My os is win8 64bit.

See forum for logs: ​http://wildfiregames.com/forum/index.php?showtopic=19804&hl=

[sanderd17]

Ok, seems like it's a problem with the deserialization of nested Maps (which are used in the Auramanager).

[sanderd17]

Workaround for the Auramanager, though it should probably be fixed in the C++ (de)serialisation part

[tom]

Using your patches, the problem has since been fixed.

[sanderd17]

In 16591:

Revert r16512 until problems with nested maps are solved. Refs #3164

[elexis]

Before sanderd17 reverted that code above, I got some mysterious crashes and aura errors. Linking this ticket for completeness: #3188.

[Itms]

I looked into the issue and it is not caused by the nested maps but by object references in maps. I would like to commit the following workaround, which clones the data before inserting it inside the map.

When it is committed, I will create a ticket for the references bug, containing a patch and some code to reproduce the error.

Please review the style and let me know.

[Itms]

Also includes some reordering of add/multiply to avoid any ordering mistake

[leper]

Any reason for using that custom function instead of clone() (from globalscripts/utility.js)?

I'd prefer not naming it like it should be used by other components (So eg. starting with lower case like that ensureExists, though we did have internal funcs starting with _ some time ago. It seems all of those are now gone though).

Apart from that it looks good. Should we also commit the new map tests too?

[Itms]

In 16929:

Revert r16591.

The problem caused by nested Maps is actually #3374.
Cloning the data object saved by the AuraManager fixes #3188.
Also, using Map fixes a serialization problem, refs #3375.

On top of those changes, some reordering of add/multiply to avoid any ordering mistake.

Fixes #3164, Refs #3374

[leper]

In 16954:

Test serialization of nested maps. Refs #3164, #3374.