Opened 9 years ago

Last modified 5 years ago

#3198 new defect

[PATCH] Send diplomacy changed message only if it actually changes

Reported by: elexis Owned by:
Priority: Should Have Milestone: Backlog
Component: UI – In-game Keywords: patch
Cc: Patch:

Description

Currently you can declare war on someone multiple times (even if you are at war already). While this is fun and helps communicating with backstabbers, it is also a waste of performance.

Attachments (2)

t3198_send_diplomacy_message_only_if_it_changes.patch (956 bytes ) - added by elexis 9 years ago.
Almost fixes it. You can still send dupes while waiting for the answer / broadcastes diplomacy message to arrive.
t3198_send_diplomacy_message_only_if_it_changes_better.patch (2.1 KB ) - added by elexis 9 years ago.
The diplomacy button will now be updated as soon as one clicks on it. It has become really hard to send dupes this way (only when spamming different diplomacies anyway).

Download all attachments as: .zip

Change History (9)

by elexis, 9 years ago

Almost fixes it. You can still send dupes while waiting for the answer / broadcastes diplomacy message to arrive.

by elexis, 9 years ago

The diplomacy button will now be updated as soon as one clicks on it. It has become really hard to send dupes this way (only when spamming different diplomacies anyway).

comment:1 by elexis, 9 years ago

Keywords: patch review added; simple removed
Milestone: BacklogAlpha 19
Summary: Send diplomacy changed message only if it actually changes[PATCH] Send diplomacy changed message only if it actually changes

comment:2 by elexis, 9 years ago

I should also mention that the diplomacy feature becomes more responsive without increasing the actual performance (turns per second).

If one player pauses the game, you can still send multiple 'diplomacy changed' messages by switching through many diplomacies on that turn. The solution would be to send only the last diplomacy changed message per turn!

comment:3 by leper, 9 years ago

Keywords: review removed

If you're already at it, the diplomacy screen should just allow changing things (tributes, diplo) and provide you with the choice to apply those changes or to discard them.

And only send a few messages (at max playernum*2 (diplo, tribute)) at that point. Would be easier than doing something like the patch for each setting and then still having some issues.

comment:4 by elexis, 9 years ago

One should make sure that if multiple types of resources are sent, that they are displayed in a single notification, like "Player X has sent 100 food, 200 wood, 300 metal and 400 stone".

comment:5 by elexis, 9 years ago

Milestone: Alpha 19Alpha 20

comment:6 by elexis, 8 years ago

Milestone: Alpha 20Backlog

Backlogging due to lack of progress.

comment:7 by Imarok, 5 years ago

Component: UI & SimulationIn-game UI

Move tickets to In-game UI as UI & Simulation got some sub components.

Note: See TracTickets for help on using tickets.