#3205 closed defect (fixed)
[PATCH] Too dark colors for playernames in multiplayer lobby and gamesetup_chat
Reported by: | fpre_O_O_O_O_O_O | Owned by: | elexis |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 20 |
Component: | Multiplayer lobby | Keywords: | patch |
Cc: | Patch: |
Description (last modified by )
Some players with short names get dark blue as the color for their nickname. Since the names are short and the color is very dark on dark background, you have a hard time reading that playername without zooming in / going closer to the screen.
This can be fixed easily by increasing the minimum brightness of the player color chosen.
This patch enlightens too dark colors by increasing the minimum lightness: attachment:t3205_enlighten_too_dark_chat_colors.patch:ticket:3205
Attachments (16)
Change History (28)
by , 9 years ago
Attachment: | lobby_color_fix.patch added |
---|
comment:1 by , 9 years ago
Description: | modified (diff) |
---|---|
Keywords: | patch review added |
Summary: | to dark colors in playernames in multiplayer lobby like dark blue as unreadable → [PATCH] Too dark colors for playernames in multiplayer lobby |
comment:2 by , 9 years ago
Description: | modified (diff) |
---|
by , 9 years ago
Attachment: | gamesetup_player_colors_in_chat.png added |
---|
new colors for chat (enlighted)
comment:3 by , 9 years ago
Summary: | [PATCH] Too dark colors for playernames in multiplayer lobby → [PATCH] Too dark colors for playernames in multiplayer lobby and gamesetup_chat |
---|
by , 9 years ago
Attachment: | new_common_color_file.patch added |
---|
new file for merging hsl to rgb function necessary for lobby and gamesetup colors into one file spreading them over to both
by , 9 years ago
Attachment: | gamesetup_xml_colors_fix.patch added |
---|
new xml file due to using color.js from gui/common/ now
by , 9 years ago
Attachment: | lobby_xml_colors_fix.patch added |
---|
new xml file due to using color.js from gui/common/ now
by , 9 years ago
Attachment: | gamesetup_colors_fix.patch added |
---|
fix player colors in gamesetup for better reading
by , 9 years ago
Attachment: | t3205_enlighten_too_dark_chat_colors.patch added |
---|
Thanks for uploading a patch with all changes in a single file. Unfortunately this patch can't be applied, since the directory names are different. This patch works for SVN. The only thing I still would change is the red color in the gamesetup chat, it looks too bright in my opinion. Not sure how to fix this without making blue unreadable again and not changing each color individually (maybe thats just the easiest way then?).
by , 9 years ago
Attachment: | comparison.png added |
---|
A comparison between the playerlist without (left) and with the patch (right). Notice how you can't read the name PA without zooming in. It seems all players with 3 letters are affected of the blue that is too dark. Also notice that most of the player colors are untouched while only those that are really too dark are fixed.
comment:5 by , 9 years ago
Description: | modified (diff) |
---|
comment:6 by , 9 years ago
The patch above changes the dark blue color of player 1 in the gamesetup chat too. However in the diplomacy menu that color is too dark too (The playername in the list and in the tooltip when tributing resources).
by , 9 years ago
Attachment: | t3205_enlighten_too_dark_chat_colors_a18.patch added |
---|
Same patch as above, but compatible to a18.
comment:7 by , 9 years ago
Keywords: | review removed |
---|
Some comments:
- Don't remove the link to StackOverflow
- Don't forget to remove the clamping function that is copied to the new file
- We should move the hardcoded color values in the code to some easily accessible variable (putting it in the new file is probably nice).
- The RGB->HSV->RGB trick to enlighten the color should be either commented, either moved to a separate function with a meaningful name (I'd prefer the latter).
The most important comment: A18 doesn't exist anymore. More seriously, we don't try to be retrocompatible and we don't release fixes for older versions (unless they are unusable on some architectures), so every fix should be designed for the development version.
by , 9 years ago
Attachment: | t3205_enlighten_too_dark_chat_colors_v2.patch added |
---|
Created the ensureMinimumLightness function. Moved player color values and functions to color.js, so that it can be used in other pages too. Moved the hardcoded color values used only in the lobby to the beginning of lobby.js Removed most of fixedColors since they were not used anywhere (which also allowed the removal of the hexToRgb and r function).
by , 9 years ago
Attachment: | t3205_enlighten_too_dark_chat_colors_v2.1.patch added |
---|
ensureMinimumLightness was incorrectly applied in gamesetup.js.
comment:10 by , 8 years ago
Rebased fpre's original patch in attachment:lobby_gamesetup_color_complete.patch and added JSdoc comments instead of regular ones. Also fixed coding style and reduced the minimum lightness of the gamesetup chat from 0.7 to 0.6.
Further refactoring and "balancing" of hardcoded color values will be done in future commits.
Thanks for the patch!
comment:11 by , 8 years ago
Nice work, I always found the dark blue names particularly annoying and difficult to read on my monitor :P
quick fix for dark colors