Changes between Initial Version and Version 1 of Ticket #3253, comment 5
- Timestamp:
- Jun 19, 2015, 4:08:46 PM (9 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #3253, comment 5
initial v1 1 sanderd17 noted on IRC today that the '''botnames are translated''' and therefore might cause an out-of-sync error when saving them. However that is not the case, since the '''host decides the playernames''' when the game is started. All clients will then see the names in the translated version of the host (with and without the patch above).1 sanderd17 noted on IRC today that the '''botnames are translated''' ~~and therefore might cause an out-of-sync error when saving them. However that is not the case, since the '''host decides the playernames''' when the game is started. All clients will then see the names in the translated version of the host (with and without the patch above).~~ 2 2 3 If you want to translate the botnames for each client individually, you would have to identify '''all places in the GUI where a playername is used''' and translate it just in time, since you can't translate in the simulation code (Player component and GuiInterface). Sometimes the name is accessed by the player assignments, sometimes by the Player component, sometimes by the simulation state. 3 ~~If you want to translate the botnames for each client individually, you would have to identify '''all places in the GUI where a playername is used''' and translate it just in time, since you can't translate in the simulation code (Player component and GuiInterface). Sometimes the name is accessed by the player assignments, sometimes by the Player component, sometimes by the simulation state.~~ 4 4 5 The patch above saves the name from the assignment to the player component, so that it is identical and not "Player X", should be good enough. 5 ~~The patch above saves the name from the assignment to the player component, so that it is identical and not "Player X", should be good enough.~~ 6 7 To be done in #3307
