[PATCH] Tribute all resources to active allies before resigning

[elexis]

Often players resign, while they still have many resources left and teammates feel like they can still win the game.

Once the user has confirmed the resign-question, he could be asked whether or not he wants to send resources to his allies before doing so (maybe at least when he has more than 100 of one resource type).

If he agrees, the diplomacy manager could open, allowing him to easily tribute. If he disagrees, he should be defeated and asked whether to leave.

[Stan]

Hey thanks for the patch here are some comments

• the use of for each is deprecated use for(x of y) or for(x in y)
• Use the let keywords when possible.
• Could you use Jsdoc on modified functions so we can generate the documentation ?

[Stan]

A19 will not have this featured (Feature and commit freeze) so pushing it to A20

[Vlad Topala]

Thanks a lot for the review. I'll do the changes and come back with a new patch.

[Stan]

I'm getting this out of the review queue until then. Keep it up :)

[Stan]

Nice ! Only thing missing is `for (let x)` instead of `for (var)`. Apart from that it looks nice :)

Feel free to take any other tickets after that one.

Keep it up :) Have you tested it ?

[Vlad Topala]

Updated the for blocks with let. Yes, I tested it by starting multiple instances of the game, creating a multiplayer game in which the instances were allied and resigning. I already got my eye on another ticket (​http://trac.wildfiregames.com/ticket/1912) but if you have any suggestions, as to what might be better, do tell.

[Stan]

Well your patch lasr patch here is for #1912 XD I think it should be fine after that add the review keyword and click accept so the ticket is assigned to you

[Stan]

The patch is not the right one :)

[Vlad Topala]

[PATCH]

[Vlad Topala]

:)) my bad. I didn't get it from your previous comment. I hope it's all good now :D.

[leper]

Read the Coding Conventions. Why add IsActive and GetAllies if you still iterate over most players, just iterate over all of them and do the checks there. No to adding that resource array to the prototype. You likely also want mutual allies, and so the team check would be pointless. There also exists a function for tributing resources already, might make sense to reuse that.

[fatherbushido]

Since it's inactive since 3 months, i made one patch taking accounts of above remarks.

[elexis]

In 17813:

Two early returns. Refs #3265.

[fatherbushido]

• if player doesn't want give his ress, we can't force him.
• if player wants give his ress, he must do it before being defeated. It's more realistic.

[elexis]

In 17853:

Defeated players are not supposed to do stuff.
Not sending resources on defeat also gives an incentive to completely defeat players.
Patch by fatherbushido, refs #3265.

[elexis]

Rewrote the ticket description.

[Imarok]

Move tickets to Simulation as UI & Simulation got some sub components.