[PATCH] Lobby - player joins not processed after rejoining the lobby

[elexis]

There is a significant problem with r16507.

It introduced the g_joined variable which is set to false when loading the lobby.js file and set to true after we successfully joined the room. All player joins will be ignored when g_joined is true. The intent is good, because it hides the join messages when the player initially joins the lobby.

However the problem arises when you get into the gamesetup and/or session and return from that to the lobby. In that case lobby.js will be reloaded and g_joined will be set back to false - and it will never be put back to true, since we didn't reconnect to the lobby.

Consequently no player joins will be processed and as a result the playerlist doesn't contain all players that are online.

You can reproduce it for the svn version by using two lobby accounts:

1. Join the lobby, host a game and return to the lobby.
2. Join the lobby with a second account and write some text.

-> Notice that the first account shows the text that was sent but doesn't have the player in the list!

Thanks to ffm for reporting that issue to me. Luckily we tested r16507 in a18 and could notice the issue before a19 will be released.

[elexis]

The latest patch on #3171 will fix this issue too!

[elexis]

Closing this ticket as it will be fixed with #3171 and since there is a third playerlist bug mentioned in comment 10 of that ticket.

[Itms]

Don't forget to remove attributes for non-fixed closed tickets.