#3300 closed defect (fixed)
[PATCH] Capturing system should entirely disable the delete button
| Reported by: | Itms | Owned by: | mimo |
|---|---|---|---|
| Priority: | Must Have | Milestone: | Alpha 19 |
| Component: | UI & Simulation | Keywords: | simple, patch |
| Cc: | sanderd17 | Patch: |
Description
Currently, if a building is below 50% CP, the Delete button gets an informative tooltip but it is still possible to press the button, which opens a useless confirmation window.
It would be better to disable completely the button, like we currently do for fogged foundations.
Attachments (3)
Change History (7)
by , 9 years ago
| Attachment: | disable_delete_button.diff added |
|---|
comment:1 by , 9 years ago
| Keywords: | review patch added |
|---|---|
| Milestone: | Backlog → Alpha 19 |
| Summary: | Capturing system should entirely disable the delete button → [PATCH] Capturing system should entirely disable the delete button |
comment:2 by , 9 years ago
Thanks for the patch. While testing it, I noticed that while the tooltip correctly says that we can't delete the building, the icon does not show any change when switching from 51% to 49%. It would be nicer if lines 699 and 705 would also return a different icon to indicate that it is disabled. If you want to give it a try, disabled button are usually grey version of the icon. Otherwise, I'll commit it like that and we'll do another ticket for the icon.
by , 9 years ago
| Attachment: | disable_delete_button_2.diff added |
|---|
New patch for this ticket, the icon "kill_small_disable" will be in the next attachment.
comment:4 by , 9 years ago
| Keywords: | review removed |
|---|
Thanks for the patch. In game, it was difficult to see any difference between the original icon and the disabled one, so I have added a cross on the disabled one. Hopefully someone will come with a better version.
The patch for this ticket.