#3305 closed defect (fixed)
[PATCH] Players can rejoin even if they were not present when the game started
| Reported by: | elexis | Owned by: | leper |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 19 |
| Component: | Core engine | Keywords: | patch |
| Cc: | Patch: |
Description
The gamesetup has a feature where players will be assignet the same the slot if they rejoin the gamesetup. The same feature is used for the session, so that clients will be assigned the same player after rejoining.
However there is a problem with that. If you join the match once, leave and then the game starts, you can still rejoin, although you were not present when the game started.
Reproduce: (1) Open a match (2) Join and disconnect with a second client (3) Start the game (with only the host) (4) The second client can rejoin as player 2, although he/she was not present when the game started.
A solution is to remove players that are not present when the game starts.
Originally posted in #3242.
Attachments (1)
Change History (3)
by , 9 years ago
| Attachment: | t3305_clear_player_assignments_when_starting_the_game_v2.patch added |
|---|
comment:2 by , 9 years ago
| Keywords: | review removed |
|---|---|
| Milestone: | Backlog → Alpha 19 |
Missing space after for, and I specified the full type, and made the loop be similar to all other iterator loops we have.
Same as attachment:t3242_clear_player_assignments_when_starting_the_game.patch:ticket:3242 but cleaned. The iterator is not invalidated since erase returns the next element of the map.