#3306 closed enhancement (fixed)
Display chat scrollback again when returning from gamesetup
Reported by: | elexis | Owned by: | elexis |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 23 |
Component: | Multiplayer lobby | Keywords: | beta |
Cc: | Patch: | Phab:D819 |
Description (last modified by )
Currently chat messages are only displayed in the OnTick()
function in lobby.js
, i.e. only once when they were received in javascript. However if you get into the gamesetup and return immediately, the chat will be blank.
This means you will miss messages (imagine someone sending you one while you were just clicking on the host game button and returned, because you noticed that someone wrote your nickname).
The XmppClient.cpp
needs to save the last N messages, since saving values in JS doesn't work (After returning from the gamesetup, the values are overwritten again, see #3287).
There is a setting lobby.history
that already remembers the number of chat messages to scroll back.
A script function must be added to JSInterface_Lobby.h
, so that one can get the scrollback in the init()
function in lobby.js
.
Change History (8)
comment:1 by , 8 years ago
Keywords: | simple added |
---|
comment:2 by , 8 years ago
Description: | modified (diff) |
---|
comment:3 by , 8 years ago
comment:4 by , 7 years ago
Keywords: | beta added |
---|
comment:6 by , 7 years ago
Description: | modified (diff) |
---|---|
Keywords: | simple removed |
Milestone: | Backlog → Alpha 23 |
Patch: | → Phab:D819 |
refs #3832