Opened 9 years ago
Closed 8 years ago
#3335 closed defect (fixed)
Shared vision: Can't ungarrison from allied structures
| Reported by: | elexis | Owned by: | |
|---|---|---|---|
| Priority: | Must Have | Milestone: | Alpha 22 |
| Component: | UI & Simulation | Keywords: | |
| Cc: | Patch: |
Description (last modified by )
If you garrisson a unit into an allied building (before having researched the shared-vision-tech at the market), then you can't ungarrisson the unit anymore, since the structure will be hidden and only its mirage will be shown in the fog of war.
If you use the developers overlay, enable and disable the reveal-map feature, then both entity and mirage will be shown (two health point bars and both structures selectable).
Expected Result: You can control all your units, and therefore be able to ungarrisson from the building. If you garrissoned that building then you should be able to see the original entity and also have its level of sight.
Attachments (1)
Change History (8)
comment:1 by , 9 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 9 years ago
| Owner: | set to |
|---|
comment:3 by , 9 years ago
| Milestone: | Backlog → Alpha 19 |
|---|---|
| Priority: | Should Have → Release Blocker |
| Summary: | Shared vision: Can't ungarrison from allied structures → [OOS] Shared vision: Can't ungarrison from allied structures |
by , 9 years ago
| Attachment: | commands.txt added |
|---|
Sample for r16941. Serializationtest crashes on turn 106, 7 turns after the garrisson command was issued.
comment:4 by , 9 years ago
| Milestone: | Alpha 19 → Backlog |
|---|---|
| Priority: | Release Blocker → Should Have |
| Summary: | [OOS] Shared vision: Can't ungarrison from allied structures → Shared vision: Can't ungarrison from allied structures |
OOS fixed in r16962. Thanks for the debugging data :)
comment:5 by , 9 years ago
| Owner: | removed |
|---|
I won't have time for programming anymore during the upcoming months.
comment:7 by , 8 years ago
| Priority: | Should Have → Must Have |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Thanks for the fix, it has been such an annoying bug and the solution wasn't too easy as we can see!
If you start a match, garrisson a unit into an allied CC and then do a serializationtest of that replay, it fails as soon as the unit is garrissoned. Unfortunately without a useful error message.
It should be obvious that the visibilities of the entities and mirages are wrong as only the mirage is visible by default; But if you reveal and unreveal the map again, both entity and its mirage are visibile.
Consequently it should also produce an OOS on rejoin. Can test it after I don't get this crash on every rejoin #3378.