#3339 closed enhancement (fixed)
[PATCH] Command line option for pid+timestamp in OOS-log filename
Reported by: | elexis | Owned by: | Imarok |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 23 |
Component: | Core engine | Keywords: | patch |
Cc: | Patch: |
Description (last modified by )
If you try to reproduce an out-of-sync error, host a game with one instance, join as a client with the second instance of 0ad and actually manage to produce an out of sync error, then both instances of 0ad will write the ooslog to the same file. Thus one file will be overwritten and you can't diff the files.
attachment:t3255_use_timestamp_and_pid_for_oosdump_filename.patch:ticket:3255 contains a patch that adds the current unix timestamp and process id to the filename and thereby prevents the file from being overwritten.
However since oos dumps are very big (dozens of megabytes) multiple files should only be created if the application was started with a specific command line argument.
Attachments (3)
Change History (8)
by , 9 years ago
Attachment: | t3339_command_line_option_ooslog_unique_v1.patch added |
---|
comment:1 by , 9 years ago
Description: | modified (diff) |
---|---|
Keywords: | review added |
Milestone: | Backlog → Alpha 19 |
Summary: | Command line option for pid+timestamp in OOS-log filename → [PATCH] Command line option for pid+timestamp in OOS-log filename |
by , 9 years ago
Attachment: | t3339_command_line_option_ooslog_unique_v1.1.patch added |
---|
Changed the name of the option to "oosdump-unique", some beautifying.
by , 9 years ago
Attachment: | t3339_command_line_option_ooslog_unique_v1.2.patch added |
---|
Uses std::time(NULL)
instead of std::time(0)
.
comment:2 by , 9 years ago
Milestone: | Alpha 19 → Alpha 20 |
---|
comment:3 by , 8 years ago
Keywords: | review removed |
---|---|
Milestone: | Alpha 20 |
Resolution: | → wontfix |
Status: | new → closed |
Linked the patch to wiki:Debugging.
Would be nice to have it (and attachment:serializationChange.patch:ticket:3292) committed to ease debugging. But on the other hand it will only be used by developers. Hence we probably shouldn't have it in the readme.txt / code.
comment:5 by , 7 years ago
Description: | modified (diff) |
---|---|
Milestone: | → Alpha 23 |
Adds the command line switch, updates readme.txt. Add
true ||
to thecit->second != expected
check in line 647 ofNetTurnManager
to trigger an out of sync error, even as the only client on a server.