[PATCH] Missing aura visualization on female

[fabio]

• female don't have aura visualization;
• it would be nice also to add a generic icon for aura visualization when a template doesn't specify a specific one (easier modding).

[elexis]

r16611 and r16625 implemented aura visualization. We only need to add this one line to make it work for the female inspiration aura too. Press tab if you want to see it without hovering a specific woman.

[elexis]

I'm not sure if it's a good idea to add a placeholder icon as it's not descriptive.

[fabio]

The idea for the placeholder icon would also be useful to report the specific icon is missing, so that one can eventually notice and fix it while having a temporary indicator that the aura is working. Something like this: Not a big deal anyway.

[Stan]

IMHO we could either have that little star above the heads of the units influenced by the female highlight them during a short time while clicking on her

[elexis]

Currently, the aura is visualized if you hover the unit that has the aura (e.g. female, temple, hero) or if you press tab (without hovering).

[elexis]

Ok the path to the placeholder might be defined in binaries/data/mods/public/simulation/components/Auras.js:

Auras.prototype.GetOverlayIcon = function(name) 
{ 
    return this.template[name].OverlayIcon || ""; 
};

Please provide a transparent image with a GPL compatible license, then we could make that happen I guess. (Not sure if leper, Itms or sanderd17 would object, but I don't mind). The file must be placed in art/textures/ui/session/auras. The existing images there have the size 128x128.

I guess you really want this to be an art ticket :D

[Stan]

Well I just want to help

[Stan]

First proposal, made on gimp 2.8 by myself so under CC-BY-SA 3.0

[elexis]

By searching for <Auras> in the binaries/data/mods/public/simulation/templates folder, you will see that there are some entities that have auras which we don't really want to see.

For example the following aura should not be visualized:

• theatron increases the territory radius by 20%

And here some auras for which I'm not sure if they should be visualized:

• walls give an armor bonus to garrisoned archers
• heroes make the building they are garrisoned in harder to capture

So I think having a placeholder icon would be wrong, as we can't really define a logic when to display them and when not to.

It is easier to add the icons for the missing auras. I didn't look at all templates, but I think only the heroes (15 of 31 auras) have missing aura icons, for example athen_hero_iphicrates.xml which increases the walk speed of units in his formation. Maybe we can use stan's icon for one of them.

[Stan]

• Maybe we should use my icon as default for heroes then
• I think it could be nice that the hero building influence be visible.
• What Icon should be used for the female ? (Which is the aim of the ticket)

[elexis]

The attached one-liner fixes the issue. If you want more than that, make a new ticket.

[elexis]

In 17335:

Show icon for the female inspiration aura. Fixes #3384