Changes between Initial Version and Version 10 of Ticket #3396


Ignore:
Timestamp:
Aug 12, 2019, 4:04:24 PM (5 years ago)
Author:
elexis
Comment:

Replying to elexis:

Duplicate code must be avoided. you can define the function in functions_global_object.js

It should be avoided, but not at the cost of refering to page-specific globals in gui/common/. The issue is related to #2640 which aims at unifying chat parsing, but this never really works out conceptually, since the three chat pages have different features, different variables, different presentation. If deduplicating / unifying the chat, it would probably be cleaner to introduce a prototype about ChatHandling that pleases features of all three pages without becoming odd, without refering to page-specific globals or names (but receiving those as arguments) (#5387).

(Also the patch has turned out to be useful in some situations, thanks again)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3396

    • Property Status newclosed
    • Property Summary Lobby - Clear chat command / button[PATCH] Lobby - Clear chat command / button
    • Property Owner set to ruiRanger
    • Property Milestone BacklogAlpha 20
    • Property Keywords patch added
    • Property Resolutionfixed