Changes between Initial Version and Version 1 of Ticket #3404


Ignore:
Timestamp:
May 30, 2016, 4:14:38 PM (8 years ago)
Author:
elexis
Comment:

(rewrote the ticket as commands.txt is very likely the wrong place to save that information)

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3404

    • Property Type enhancement → defect
    • Property Summary Save ingame-time in commands.txt → Adapt replays for variable turn length

  • Ticket #3404 – Description

    initial v1  
    1 This ticket is a preparation for the use of '''variable turn lengths''' (#69). In case we use them, but don't update the format of the commands.txt file, we can only derive the ingame time by summarizing all turn lengths of all previous turns.
     1This ticket deals with adapting the '''replay menu''' to '''variable turn lengths''' (#3752, #69).
    22
    3 * '''Debugging:''' If you want to find the commands issued in a commands.txt file at a given time, you'd have to run a script to find the looked-for turn number. Even without the variable turn length, you have to compute the turn number first, given the ingame time. If we save the ingame time like "hh:mm:ss.ms" then you can find the given turn immediately.
     3Reading the entire `commands.txt` file to derive the total game duration of a replay is  an I/O-heavy task, as the previous iterations of the patches in #3258 had shown.
    44
    5 * '''Performance boost replay-menu:''' (#3258) The performance imrpovement of at least 2 orders of magnitude can be kept, as long as only the last line of the commands.txt file needs to be read to find the total duration of the game.
    6 
     5If #4020 can be solved, the duration could be saved when ending the game (probably `metadata.json` rather than `commands.txt` or the replaylist cache  #3433).