Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3408 closed defect (fixed)

[PATCH] Don't create empty commands.txt when canceling the gamesetup

Reported by: elexis Owned by: leper
Priority: Should Have Milestone: Alpha 19
Component: Core engine Keywords: patch
Cc: Patch:

Description

Currently the commands.txt file and directory will be created as soon as you enter the gamesetup. If you cancel it, you will have that useless file leftover.

To solve this problem, we just need to move the creation of that file from the CReplayLogger constructor to CReplayLogger::StartGame.

Refs #9 #3255 #3258

Attachments (1)

t3408_no_empty_commands_txt_v1.patch​ (1.6 KB ) - added by elexis 9 years ago.

Download all attachments as: .zip

Change History (3)

by elexis, 9 years ago

Attachment: t3408_no_empty_commands_txt_v1.patch​ added

comment:1 by leper, 9 years ago

Owner: set to leper
Resolution: → fixed
Status: new → closed

In 17004:

Create commands.txt only when actually starting the game. Patch by elexis. Fixes #3408.

comment:2 by leper, 9 years ago

Keywords: review removed

Thanks for the patch. Don't forget to initialize pointers though.

Note: See TracTickets for help on using tickets.