Changes between Initial Version and Version 1 of Ticket #3433, comment 25


Ignore:
Timestamp:
Dec 7, 2016, 5:09:50 PM (7 years ago)
Author:
Vladislav Belov

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3433, comment 25

    initial v1  
    22> Strange, I tested it again and it didn't crash, but just printed an error.
    33> But it seems like JS_ReportError returns the function. So I think it would be better to just print the error with `LOGERROR` and replace the invalid cache.
    4 Yeah, i.e. there's just `return false;` in the JSInterface_IGUIObject.cpp. I'm not sure what should be there: LOGERROR or JS_ReportError (probably it sets some flags in the SM, and uses internal report handling):
     4Yeah, i.e. there's just `JS_ReportError(...); return false;` in the JSInterface_IGUIObject.cpp. I'm not sure what should be there: LOGERROR or JS_ReportError (probably it sets some flags in the SM, and uses internal report handling):
    55{{{
    66    // JS_ReportError by itself doesn't seem to set a JS-style exception, and so