Changes between Version 4 and Version 5 of Ticket #3433, comment 27


Ignore:
Timestamp:
Dec 15, 2016, 12:38:41 AM (7 years ago)
Author:
Vladislav Belov

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #3433, comment 27

    v4 v5  
    16162. The `scriptInterface.GetProperty(replay, "directory", fileName)` return `false` if there was any error, but you code doesn't check that, and still works, even the `directory` is invalid, empty I think.
    1717
    18 3. Why do you call `wunlink(cacheFileName)`, this file is opened only by the ifstream?
     183. Why break on `if (SDL_QuitRequested())` and not the return?
    1919
    20 4. Why break on `if (SDL_QuitRequested())` and not the return?
     204. No needs to have `u32 i = 0;` as global (VisualReplay.cpp:243), move to the loop `for (u32 j = 0, i = 0; j < replaysLength; ++j)`.
    2121
    22 5. No needs to have `u32 i = 0;` as global (VisualReplay.cpp:243), move to the loop `for (u32 j = 0, i = 0; j < replaysLength; ++j)`.
    23 
    24 6. I'm not sure, just wondering, maybe use the same name style in the `scriptInterface.SetProperty(replayData, "fileSize", (u32)fileSize)` as other attributes: `filesize` or `file_size`.
     225. I'm not sure, just wondering, maybe use the same name style in the `scriptInterface.SetProperty(replayData, "fileSize", (u32)fileSize)` as other attributes: `filesize` or `file_size`.