#3436 closed enhancement (fixed)
[PATCH] Replay Menu - singleplayer / multiplayer filter
| Reported by: | elexis | Owned by: | Imarok |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 21 |
| Component: | UI & Simulation | Keywords: | patch |
| Cc: | Imarok | Patch: |
Description
It would be nice to filter singleplayer / multiplayer games in the replay menu.
Whether a game is networked should be should to the commands.txt file.
If we continue to display incompatible replays, we should filter those by the turn length, which are 200ms for singleplayer and 500ms for multiplayer.
Feature suggested by Stan.
Attachments (9)
Change History (16)
comment:1 by , 8 years ago
| Cc: | added |
|---|---|
| Keywords: | simple added |
comment:2 by , 8 years ago
| Owner: | set to |
|---|
by , 8 years ago
| Attachment: | 3436_singMulti_filter.patch added |
|---|
Add a filter for single player/multiplayer and one for the victory conditions
comment:3 by , 8 years ago
| Keywords: | review patch added |
|---|---|
| Summary: | Replay Menu - singleplayer / multiplayer filter → [PATCH] Replay Menu - singleplayer / multiplayer filter |
by , 8 years ago
| Attachment: | 3436_singMulti_filter_v4.patch added |
|---|
Renamed singleMultiPlayer to singleplayer
by , 8 years ago
| Attachment: | 3436_singMulti_filter_v6.patch added |
|---|
Some little changes suggested by elexis
comment:4 by , 8 years ago
| Keywords: | simple removed |
|---|---|
| Milestone: | Backlog → Alpha 21 |
- Since there are no labels in front of the dropdowns, ("Single or multiplayer", "Any gamemode", "Rated or unrated") might be a better indication than ("Any", "Any", "Any").
by , 8 years ago
| Attachment: | 3436_singMulti_filter_v6.1.patch added |
|---|
The nonAIPlayers method of detecting singleplayer is not bad. It doesn't work with unassigned players, but that shouldn't be a problem and might change at some point (ticket somewhere) (also don't ask me how we should sort games which are played by exclusively AI). Fixed indentation in the xml and the second line of the if's. Added the replay.attribs.settings.GameType check.
by , 8 years ago
| Attachment: | 3436_singMulti_filter_v6.3.patch added |
|---|
Also check total number of players
comment:6 by , 8 years ago
| Keywords: | review removed |
|---|
Changing replay.attribs is a big nono to me. It should be read-only and contain the unadulterated data of the file. Setting replay.isRated seems cleaner to me.
Also changed strings a bit again.
Thanks for the patch!
Adding a new column to the table sounds like pain. A new entry below the compatibility filter sounds ok.
Also would be nice to be able to filter by victory condition (wonder games ftw).