Opened 9 years ago
Closed 8 years ago
#3446 closed defect (fixed)
[PATCH] Replay menu should react to the user trying to quit
Reported by: | elexis | Owned by: | elexis |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 20 |
Component: | Core engine | Keywords: | patch |
Cc: | Patch: |
Description
As mentioned in #3433, it can take quite some time to initially read the commands.txt files on the harddisk (a minute on my machine).
Currently this process is uninterruptable as it doesn't react to SIGINT. You have to use SIGKILL, i.e. kill it with absolute force (kill -9
on linux).
Ideally people can just hit Alt+F4 or Ctrl+c to stop loading those files.
To reproduce the long loading time on linux, you have to drop the HDD cache using
echo 3 | sudo tee /proc/sys/vm/drop_caches
I agree that this long-loading isn't a big one, so it could be pushed to a20. On the other hand, users that don't know the source of this issue might panic.
We should also add the warning to the main menu in attachment:t3440_fix_main_menu_entry_add_warning_v2.patch:ticket:3440
Attachments (1)
Change History (5)
by , 9 years ago
Attachment: | t3446_catch_SDL_QUIT_v1.patch added |
---|
comment:1 by , 9 years ago
Owner: | set to |
---|
comment:2 by , 9 years ago
Milestone: | Alpha 19 → Alpha 20 |
---|
comment:3 by , 8 years ago
Keywords: | review removed |
---|---|
Priority: | Should Have → Must Have |
Summary: | [PATCH] Cancel replay menu loading with Alt+F4 → [PATCH] Replay menu should react to the user trying to quit |
Thanks Itms for taking a look at this patch few days ago!
SDL_PeepEvents
only checks if there is a matching event queued, but doesn't remove it. Browsing the documentation I found the fileSDL_quit.h
, which is included in SDL 1.2 and 2 and contains the exact same codeSDL_QuitRequested()
!