Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3490 closed enhancement (fixed)

[PATCH] Historical names for british and gaul fishing ships

Reported by: Stan Owned by: Stan
Priority: Must Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by elexis)

Revision : r17108

Steps to reproduce :

  • Build a fishing boat at the crannoc and look at his name

OR

  • Create it in Atlas, and launch the simulation.

it reads /Fishing Boat/ while it should be a specific name.

Attachments (2)

3490.diff (1.2 KB ) - added by Stan 8 years ago.
This patch fixes it. The name in the template was incorrect. Also did it for the gaul boat, because they are the same :)
3490.2.diff (1.3 KB ) - added by Stan 8 years ago.
Translations for special strings.

Download all attachments as: .zip

Change History (12)

by Stan, 8 years ago

Attachment: 3490.diff added

This patch fixes it. The name in the template was incorrect. Also did it for the gaul boat, because they are the same :)

comment:1 by Stan, 8 years ago

Keywords: patch review added
Milestone: BacklogAlpha 20
Owner: set to Stan
Status: newassigned
Summary: Brit fishing boat has invalid specific name[PATCH] Brit fishing boat has invalid specific name

Pushing it to A20 since it will likely break translations. It shouldn't though cause specific names aren't supposed to be translated.

comment:2 by leper, 8 years ago

Keywords: patch review removed
Milestone: Alpha 20
Resolution: invalid
Status: assignedclosed

Either provide a patch with a proper specific name (or start something to find one on the forums) or leave it as it is, since it doesn't really help hiding it.

comment:3 by Stan, 8 years ago

Milestone: Alpha 20
Resolution: invalid
Status: closedreopened

by Stan, 8 years ago

Attachment: 3490.2.diff added

Translations for special strings.

comment:5 by Stan, 8 years ago

Keywords: patch review added

comment:6 by elexis, 8 years ago

Component: I18n & L10nUI & Simulation
Description: modified (diff)
Summary: [PATCH] Brit fishing boat has invalid specific name[PATCH] Historical names for british and gaul fishing ships
Type: defectenhancement

If we already have some historical info at hand, adding the <History> tag would be nice too. Maybe there might be more people on the forum to review/author historical data.

comment:7 by Stan, 8 years ago

Status: reopenednew

comment:8 by Stan, 8 years ago

Status: newassigned

comment:9 by mimo, 8 years ago

Resolution: fixed
Status: assignedclosed

In 17321:

add specific names for gaul and brit fishing ships, fixes #3490, patch from stanislas69

comment:10 by mimo, 8 years ago

Keywords: review removed

thanks for the patch

Note: See TracTickets for help on using tickets.