Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#3510 closed defect (fixed)

[PATCH] Adjust HP for Celtic and Spartan female citizens

Reported by: Palaxin Owned by: scythetwirler
Priority: Should Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by Palaxin)

In r16757 HP for female citizens were halfed. Since Celtic and Spartan females have hardcoded HP in their templates, they have become quite overpowered compared to "normal" females.

A simple fix is to adjust the HP in the civ templates. The float HP of some Celtic females are not rounded from 37.5 to 38, so at full HP 38/37.5 is displayed. Perhaps a new ticket for this problem is needed?

The other solution is to add two autoresearch technologies which multiply the standard female HP by the desired factor. So you have only to adjust the HP once and they are scaled automatically for Celts and Spartans. Interestingly the display problem did not occur here. The technology names and descriptions could be improved, I just used a shortened version of the female citizen template history. I also included the bonus attack damage for Celtic females in the new technology.

Attachments (5)

female_simple.patch (1.5 KB ) - added by Palaxin 8 years ago.
defect_hp_display.jpg (472.4 KB ) - added by Palaxin 8 years ago.
correct_hp_display.jpg (488.0 KB ) - added by Palaxin 8 years ago.
female_technologies.patch (3.8 KB ) - added by Palaxin 8 years ago.
femal_rel_templates_not_working.patch (2.0 KB ) - added by Palaxin 8 years ago.

Download all attachments as: .zip

Change History (17)

by Palaxin, 8 years ago

Attachment: female_simple.patch added

by Palaxin, 8 years ago

Attachment: defect_hp_display.jpg added

by Palaxin, 8 years ago

Attachment: correct_hp_display.jpg added

by Palaxin, 8 years ago

Attachment: female_technologies.patch added

comment:1 by Palaxin, 8 years ago

Description: modified (diff)

comment:2 by Palaxin, 8 years ago

Description: modified (diff)

comment:3 by elexis, 8 years ago

Milestone: BacklogAlpha 20
Priority: Must HaveShould Have

comment:4 by Palaxin, 8 years ago

I just realized that the technology "health_females_01.json" also gives 50% bonus HP. Since "multiply" affects only the base HP value we get different HP values for the following two cases (let's take Spartan females with 80% increased base HP as example):

  • base HP increase with autoresearch: 25 + 0.8*25 + 0.5*25 = 2.3*25 = 57.5 HP
  • hardcoded increased base HP: 45 + 0.5*45 = 1.5*45 = 67.5 HP

So it seems only the simple fix won't change the current relative difference of max HP between the civs. A nice feature would be to implement an additional "multiply" function that does not affect base values but current values instead. Sadly my skills currently don't allow me to do this myself...

comment:5 by Stan, 8 years ago

Hey, thank you for working on this. Have a look at : #2936

comment:6 by Palaxin, 8 years ago

Oh yes that would be nice! Thank you for the link.

comment:7 by Palaxin, 8 years ago

The technologies have one major disadvantage: If you are under control of female citizens of a different civ (e.g. a special scenario or capturing) they will get or lose the bonus though in my opinion they shouldn't. So I'd really prefer to define the HP in the templates as it is done now --> simple patch.

Thinking further this problem probably also affects other technologies: hellenic structures have autoresearched 10% bonus HP, but what if you captured them with a non-hellenic civ or even brits/gauls which have -20% HP for structures?

Last edited 8 years ago by Palaxin (previous) (diff)

comment:8 by Palaxin, 8 years ago

I tried to make another patch version with the relative templates implemented in r17386. Sadly it does not work that way. I've no clue what is wrong...

comment:9 by scythetwirler, 8 years ago

Seems to work for me. There hasn't been an autobuild since r17386 though, so you'd need to compile it yourself to see the effects.

comment:10 by Palaxin, 8 years ago

Ahhh that makes sense :) In fact I didn't compile it myself. Thank you. I will wait for the next autobuild to test it though

Last edited 8 years ago by Palaxin (previous) (diff)

comment:11 by scythetwirler, 8 years ago

Owner: set to scythetwirler
Resolution: fixed
Status: newclosed

In 17514:

Adjusts female citizen HP cost correctly using relative templates. Fixes #3510. Patch by Palaxin.

comment:12 by scythetwirler, 8 years ago

Keywords: review removed

Thanks for the patch. :)

Last edited 8 years ago by scythetwirler (previous) (diff)
Note: See TracTickets for help on using tickets.