Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3524 closed defect (fixed)

[PATCH] Wrong button order when deleting replays

Reported by: elexis Owned by: Stan
Priority: Should Have Milestone: Alpha 19
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by elexis)

Yet another one...Refs #2636 #2837, #3200 #3483

The convention is to have "No" on the left-hand-side as in windows. More importantly because hitting escape always triggers a click on the first button and we don't want people deleting replays by accident.

We should search for messageBox in JS files and fix all wrong occurances.

Attachments (2)

3524.diff​ (3.7 KB ) - added by Stan 9 years ago.
Should fix all the inconsistencies
3524.2.diff​ (3.7 KB ) - added by Stan 9 years ago.
Fix the order in session.js

Download all attachments as: .zip

Change History (6)

comment:1 by elexis, 9 years ago

Description: modified (diff)

comment:2 by Stan, 9 years ago

Owner: set to Stan
Status: new → assigned

by Stan, 9 years ago

Attachment: 3524.diff​ added

Should fix all the inconsistencies

by Stan, 9 years ago

Attachment: 3524.2.diff​ added

Fix the order in session.js

comment:3 by ben, 9 years ago

Resolution: → fixed
Status: assigned → closed

In 17135:

Fixes more dialog button order issues, based on patch by stanislas69, fixes #3524

comment:4 by historic_bruno, 9 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.