#3537 closed defect (fixed)
[PATCH] Persist Match Settings - Have a rated game with cheats enabled
| Reported by: | elexis | Owned by: | JoshuaJB |
|---|---|---|---|
| Priority: | Must Have | Milestone: | Alpha 19 |
| Component: | UI & Simulation | Keywords: | |
| Cc: | Patch: |
Description
Being able to load the previous gamesetup (presist-match-settings) has the bug of allowing a rated game with cheats enabled.
Reproduce:
- Delete
matchsettings.mp.jsonin the config directory (see wiki:GameDataPaths) - Open a non-lobby multiplayer game with cheats enabled (you don't need to start the game, clicking on back is sufficient)
- Start a lobbied multiplayer game.
Ratings will be checked by default, but cheats are still active. Select a tree and type "wololo" into the chat to confirm this.
Attachments (1)
Change History (6)
comment:1 by , 8 years ago
| Milestone: | Backlog → Alpha 19 |
|---|---|
| Priority: | Should Have → Must Have |
by , 8 years ago
| Attachment: | t3537_prohibit_rated_games_with_cheats_v1.patch added |
|---|
comment:2 by , 8 years ago
| Keywords: | patch added; simple removed |
|---|---|
| Summary: | Persist Match Settings - Have a rated game with cheats enabled → [PATCH] Persist Match Settings - Have a rated game with cheats enabled |
comment:3 by , 8 years ago
| Keywords: | reviewed added |
|---|
Patch looks good. No additional code and cleaner logic.
Also, note that this ticket was not tagged for review.
Note:
See TracTickets
for help on using tickets.
A malicious server might still mess with those settings. It would be better if the clients would also do a separate check and not accept invalid settings.