[PATCH] Enabling cheats should display a message in the gamesetup

[elexis]

Usually a lot of settings change in a game and nobody actually reads all of them. Some hosting trolls enable cheats just before the game starts and thus are the only player who is aware of that.

We should add a notification if the cheats-setting is changed to prevent that.

Current patch look

[elexis]

Since people don't read all messages, displaying a message doesn't help.

We should rather some red text (maybe with an icon) that is displayed outside of the chat area, maybe left of the start/cancel buttons?

[Stan]

A proposal.

[Stan]

I'm pushing it to A20 because of the string freeze. If anyone feels like breaking the rules, feel free to push it back to A19

[elexis]

Would be good to implement this for a19, just to reduce the amount of attack vectors of trolls.

I think we wouldn't need to break the translation freeze, since having this string in english would still be better than not having it at all.

[Josh]

Warning overlap

[Josh]

The warning needs to be in a location where it does not overlap other objects. See this example:

I'd suggest a popup when readying which warns the user that cheats have been enabled and asks them to acknowledge that they still want to ready (with the option to cancel).

[Stan]

Current State, Patch Incoming

[Stan]

Use a popup instead of the red message.

[Stan]

• Add a dialog popup
• Add a boolean not to spam the user each time he presses I'm ready.
• Add a documented function to turn of or on the cheat menu popup.

[Stan]

Removing the assignement as I'm not able to do what is wanted. Ticket is now free for anyone to work on it. Removing patch and review, as they are not relevant anymore even though they work.

[elexis]

If we were honest, we would show the message if cheats are enabled or if we don't play a rated game, since every non-rated game allows some cheats like unit-promotion, reveal-map and control-all-units. This patch would do that.

[elexis]

Sample: Notice the element is aligned right not left and the element starts at the very left. So if there are huge translations it still fits.

---

If we go with a new gamesetting that allows developer-tools, then we still need to warn about those in this message, if we want to address this issue.

[leper]

In 17175:

Show a message about cheats being enabled in gamesetup. Patch by elexis. Fixes #3546.

[leper]

Thanks for the patch. Depending on the translation of the text it might lead to overlaps with option tooltips for some languages (eg Gaelic) on minimum resolution, but first having the translation would help.