Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#3546 closed enhancement (fixed)

[PATCH] Enabling cheats should display a message in the gamesetup

Reported by: elexis Owned by: leper
Priority: Should Have Milestone: Alpha 19
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description (last modified by stanislas69)

Usually a lot of settings change in a game and nobody actually reads all of them. Some hosting trolls enable cheats just before the game starts and thus are the only player who is aware of that.

We should add a notification if the cheats-setting is changed to prevent that.

Current patch look

http://trac.wildfiregames.com/raw-attachment/ticket/3546/CheatPopup.png

Attachments (8)

3546.diff (1.7 KB) - added by stanislas69 4 years ago.
A proposal.
CheatWarning.png (990.1 KB) - added by stanislas69 4 years ago.
screenshot0005.png (652.5 KB) - added by Josh 4 years ago.
Warning overlap
CheatPopup.png (926.4 KB) - added by stanislas69 4 years ago.
Current State, Patch Incoming
3546.1.diff (3.4 KB) - added by stanislas69 4 years ago.
Use a popup instead of the red message.
t3546_cheat_alert_v3.patch (2.2 KB) - added by elexis 4 years ago.
cheats_active.jpg (19.0 KB) - added by elexis 4 years ago.
t3546_cheat_alert_v3.1.patch (2.8 KB) - added by elexis 4 years ago.
If we were honest, we would show the message if cheats are enabled or if we don't play a rated game, since every non-rated game allows some cheats like unit-promotion, reveal-map and control-all-units. This patch would do that.

Change History (20)

comment:1 Changed 4 years ago by elexis

Since people don't read all messages, displaying a message doesn't help.

We should rather some red text (maybe with an icon) that is displayed outside of the chat area, maybe left of the start/cancel buttons?

Changed 4 years ago by stanislas69

Attachment: 3546.diff added

A proposal.

Changed 4 years ago by stanislas69

Attachment: CheatWarning.png added

comment:2 Changed 4 years ago by stanislas69

Description: modified (diff)
Keywords: patch review added
Milestone: BacklogAlpha 20
Owner: set to stanislas69
Status: newassigned
Summary: Enabling cheats should display a message in the gamesetup[PATCH] Enabling cheats should display a message in the gamesetup

I'm pushing it to A20 because of the string freeze. If anyone feels like breaking the rules, feel free to push it back to A19

comment:3 Changed 4 years ago by elexis

Milestone: Alpha 20Alpha 19

Would be good to implement this for a19, just to reduce the amount of attack vectors of trolls.

I think we wouldn't need to break the translation freeze, since having this string in english would still be better than not having it at all.

Changed 4 years ago by Josh

Attachment: screenshot0005.png added

Warning overlap

comment:4 Changed 4 years ago by Josh

The warning needs to be in a location where it does not overlap other objects. See this example: Warning overlap

I'd suggest a popup when readying which warns the user that cheats have been enabled and asks them to acknowledge that they still want to ready (with the option to cancel).

comment:5 Changed 4 years ago by Josh

Keywords: review removed

Changed 4 years ago by stanislas69

Attachment: CheatPopup.png added

Current State, Patch Incoming

Changed 4 years ago by stanislas69

Attachment: 3546.1.diff added

Use a popup instead of the red message.

comment:6 Changed 4 years ago by stanislas69

Description: modified (diff)
Keywords: review added
  • Add a dialog popup
  • Add a boolean not to spam the user each time he presses I'm ready.
  • Add a documented function to turn of or on the cheat menu popup.

comment:7 Changed 4 years ago by stanislas69

Keywords: patch review removed
Owner: stanislas69 deleted
Status: assignednew
Summary: [PATCH] Enabling cheats should display a message in the gamesetupEnabling cheats should display a message in the gamesetup

Removing the assignement as I'm not able to do what is wanted. Ticket is now free for anyone to work on it. Removing patch and review, as they are not relevant anymore even though they work.

comment:8 Changed 4 years ago by leper

Milestone: Alpha 19Alpha 20

Changed 4 years ago by elexis

Attachment: t3546_cheat_alert_v3.patch added

comment:9 Changed 4 years ago by elexis

Keywords: patch review added
Milestone: Alpha 20Alpha 19
Priority: Must HaveShould Have
Summary: Enabling cheats should display a message in the gamesetup[PATCH] Enabling cheats should display a message in the gamesetup
Type: defectenhancement

Changed 4 years ago by elexis

Attachment: cheats_active.jpg added

Changed 4 years ago by elexis

If we were honest, we would show the message if cheats are enabled or if we don't play a rated game, since every non-rated game allows some cheats like unit-promotion, reveal-map and control-all-units. This patch would do that.

comment:10 Changed 4 years ago by elexis

Sample: http://trac.wildfiregames.com/raw-attachment/ticket/3546/cheats_active.jpg Notice the element is aligned right not left and the element starts at the very left. So if there are huge translations it still fits.


If we go with a new gamesetting that allows developer-tools, then we still need to warn about those in this message, if we want to address this issue.

comment:11 Changed 4 years ago by leper

Owner: set to leper
Resolution: fixed
Status: newclosed

In 17175:

Show a message about cheats being enabled in gamesetup. Patch by elexis. Fixes #3546.

comment:12 Changed 4 years ago by leper

Keywords: review removed

Thanks for the patch. Depending on the translation of the text it might lead to overlaps with option tooltips for some languages (eg Gaelic) on minimum resolution, but first having the translation would help.

Note: See TracTickets for help on using tickets.